From: Andre Przywara <andre.przywara@amd.com>
To: linux-hotplug@vger.kernel.org
Subject: [PATCH]: make /dev/cpu/<n>/cpuid world readable
Date: Thu, 23 Apr 2009 19:32:51 +0000 [thread overview]
Message-ID: <49F0C263.6010102@amd.com> (raw)
Hi,
as I don't see any security implications, to be actually useful
/dev/cpu/<n>/cpuid should be world readable. The cpuid instruction can
be called from userspace anyway, so there is nothing to hide.
The device does not support any write operation, so 0444 should suffice.
Please apply so that distributions can follow.
Regards,
Andre.
Signed-off-by: Andre Przywara <andre.przywara@amd.com>
diff --git a/rules/rules.d/50-udev-default.rules b/rules/rules.d/50-udev-default.rules
index 240cb3b..72e5b55 100644
--- a/rules/rules.d/50-udev-default.rules
+++ b/rules/rules.d/50-udev-default.rules
@@ -95,7 +95,7 @@ SUBSYSTEM="aoe", KERNEL="err", MODE="0440"
KERNEL="tun", NAME="net/%k", MODE="0666"
# CPU
-KERNEL="cpu[0-9]*", NAME="cpu/%n/cpuid"
+KERNEL="cpu[0-9]*", NAME="cpu/%n/cpuid", MODE="0444"
KERNEL="msr[0-9]*", NAME="cpu/%n/msr"
KERNEL="microcode", NAME="cpu/microcode", MODE="0600"
--
Andre Przywara
AMD-Operating System Research Center (OSRC), Dresden, Germany
Tel: +49 351 488-3567-12
----to satisfy European Law for business letters:
Advanced Micro Devices GmbH
Karl-Hammerschmidt-Str. 34, 85609 Dornach b. Muenchen
Geschaeftsfuehrer: Jochen Polster; Thomas M. McCoy; Giuliano Meroni
Sitz: Dornach, Gemeinde Aschheim, Landkreis Muenchen
Registergericht Muenchen, HRB Nr. 43632
next reply other threads:[~2009-04-23 19:32 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-23 19:32 Andre Przywara [this message]
2009-04-23 23:59 ` [PATCH]: make /dev/cpu/<n>/cpuid world readable Kay Sievers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49F0C263.6010102@amd.com \
--to=andre.przywara@amd.com \
--cc=linux-hotplug@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).