[PATCH]: make /dev/cpu/<n>/cpuid world readable

[PATCH]: make /dev/cpu/<n>/cpuid world readable

[Andre Przywara]

Hi,

as I don't see any security implications, to be actually useful 
/dev/cpu/<n>/cpuid should be world readable. The cpuid instruction can 
be called from userspace anyway, so there is nothing to hide.
The device does not support any write operation, so 0444 should suffice.
Please apply so that distributions can follow.

Regards,
Andre.

Signed-off-by: Andre Przywara <andre.przywara@amd.com>

diff --git a/rules/rules.d/50-udev-default.rules b/rules/rules.d/50-udev-default.rules
index 240cb3b..72e5b55 100644
--- a/rules/rules.d/50-udev-default.rules
+++ b/rules/rules.d/50-udev-default.rules
@@ -95,7 +95,7 @@ SUBSYSTEM="aoe", KERNEL="err", MODE="0440"
 KERNEL="tun",                 NAME="net/%k", MODE="0666"

 # CPU
-KERNEL="cpu[0-9]*",           NAME="cpu/%n/cpuid"
+KERNEL="cpu[0-9]*",           NAME="cpu/%n/cpuid", MODE="0444"
 KERNEL="msr[0-9]*",           NAME="cpu/%n/msr"
 KERNEL="microcode",           NAME="cpu/microcode", MODE="0600"

--
Andre Przywara
AMD-Operating System Research Center (OSRC), Dresden, Germany
Tel: +49 351 488-3567-12
----to satisfy European Law for business letters:
Advanced Micro Devices GmbH
Karl-Hammerschmidt-Str. 34, 85609 Dornach b. Muenchen
Geschaeftsfuehrer: Jochen Polster; Thomas M. McCoy; Giuliano Meroni
Sitz: Dornach, Gemeinde Aschheim, Landkreis Muenchen
Registergericht Muenchen, HRB Nr. 43632

Re: [PATCH]: make /dev/cpu/<n>/cpuid world readable

[Kay Sievers]

On Thu, Apr 23, 2009 at 21:32, Andre Przywara <andre.przywara@amd.com> wrote:
> as I don't see any security implications, to be actually useful
> /dev/cpu/<n>/cpuid should be world readable. The cpuid instruction can be
> called from userspace anyway, so there is nothing to hide.

Applied.

Thanks,
Kay