From mboxrd@z Thu Jan  1 00:00:00 1970
From: Olaf <mailinglists@ban-solms.de>
Date: Tue, 12 May 2009 20:31:07 +0000
Subject: Re: util-linux-ng required? which version?
Message-Id: <4A09DC8B.4080504@ban-solms.de>
List-Id: <linux-hotplug.vger.kernel.org>
References: <200905111019.20478.zzam@gentoo.org>
In-Reply-To: <200905111019.20478.zzam@gentoo.org>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: linux-hotplug@vger.kernel.org

Karel Zak wrote:

>> Building util-linux-ng 2.15 using --with-fsprobe=builtin, without having  
>> previously built e2fsprogs, gives me:
> [...]
>> read.c:28:23: error: uuid/uuid.h: No such file or directory
>> make[3]: *** [read.lo] Error 1
>> make[3]: *** Waiting for unfinished jobs....
> 
>  Thanks for your report. Fixed (see below). 

Builds fine now, thanks Karel!

I think util-linux-ng is missing some kind of make install libblkid?
Otherwise e2fsprogs with --disable-libblkid complains about not being 
able to find external blkid library.

Or am I missing something trivial? (would not be the first time ...)


>  The libuuid should be optional for u-l-ng. BUT it's recommended to
>  link mkswap against libuuid, so after e2fsprogs installation you can
>  rebuild and reinstall util-linux-ng. For example for RPM it's not a
>  problem when A depends on B and B on A. (I hope:-)

Better keep your fingers crossed then ;-)


Olaf

> From cdd17c7a73cab10a34bf80616225b8215ac4e2ed Mon Sep 17 00:00:00 2001
> From: Karel Zak <kzak@redhat.com>
> Date: Tue, 12 May 2009 21:22:19 +0200
> Subject: [PATCH] blkid: make libuuid optional
> 
> read.c:28:23: error: uuid/uuid.h: No such file or directory
> make[3]: *** [read.lo] Error 1
> make[3]: *** Waiting for unfinished jobs....
> 
> Reported-by: Olaf <mailinglists@ban-solms.de>
> Signed-off-by: Karel Zak <kzak@redhat.com>
> ---
>  libs/blkid/src/config.c   |    3 ---
>  libs/blkid/src/evaluate.c |    3 ---
>  libs/blkid/src/read.c     |    1 -
>  3 files changed, 0 insertions(+), 7 deletions(-)
> 
> diff --git a/libs/blkid/src/config.c b/libs/blkid/src/config.c
> index 2e59218..9091736 100644
> --- a/libs/blkid/src/config.c
> +++ b/libs/blkid/src/config.c
> @@ -24,9 +24,6 @@
>  #include <errno.h>
>  #endif
>  #include <stdint.h>
> -#ifdef HAVE_LIBUUID
> -#include <uuid/uuid.h>
> -#endif
>  #include <stdarg.h>
>  
>  #include "blkdev.h"
> diff --git a/libs/blkid/src/evaluate.c b/libs/blkid/src/evaluate.c
> index a9c9fba..f0ae126 100644
> --- a/libs/blkid/src/evaluate.c
> +++ b/libs/blkid/src/evaluate.c
> @@ -27,9 +27,6 @@
>  #include <errno.h>
>  #endif
>  #include <stdint.h>
> -#ifdef HAVE_LIBUUID
> -#include <uuid/uuid.h>
> -#endif
>  #include <stdarg.h>
>  
>  #include "pathnames.h"
> diff --git a/libs/blkid/src/read.c b/libs/blkid/src/read.c
> index 4163874..b5e9cd0 100644
> --- a/libs/blkid/src/read.c
> +++ b/libs/blkid/src/read.c
> @@ -25,7 +25,6 @@
>  #endif
>  
>  #include "blkidP.h"
> -#include "uuid/uuid.h"
>  
>  #ifdef HAVE_STRTOULL
>  #define STRTOULL strtoull /* defined in stdlib.h if you try hard enough */