util-linux-ng required? which version?

util-linux-ng required? which version?

[Matthias Schwarzott]

Hi Kay!
I have seen, udev-git now removed vol_id and requires blkid from latest 
util-linux-ng? What version does "latest" mean?
I have util-linux-2.15 installed, and this is the latest released version 
according to its homepage.

Regards
Matthias

Re: util-linux-ng required? which version?

[Matthias Schwarzott]

On Montag, 11. Mai 2009, Matthias Schwarzott wrote:
> Hi Kay!
> I have seen, udev-git now removed vol_id and requires blkid from latest
> util-linux-ng? What version does "latest" mean?
> I have util-linux-2.15 installed, and this is the latest released version
> according to its homepage.

Ah I guess 2.15 should be fine (according to changelog), but on gentoo up to 
now blkid and libblkid is provided by e2fsprogs.
So changing configure options and using e2fsprogs-1.41.5 that canuse external 
provided blkid should be enough.
Is this correct?

Regards
Matthias

Re: util-linux-ng required? which version?

[Karel Zak]

On Mon, May 11, 2009 at 11:50:07AM +0200, Matthias Schwarzott wrote:
> On Montag, 11. Mai 2009, Matthias Schwarzott wrote:
> > Hi Kay!
> > I have seen, udev-git now removed vol_id and requires blkid from latest
> > util-linux-ng? What version does "latest" mean?
> > I have util-linux-2.15 installed, and this is the latest released version
> > according to its homepage.
> 
> Ah I guess 2.15 should be fine (according to changelog), but on gentoo up to 
> now blkid and libblkid is provided by e2fsprogs.

 just note that libblkid from e2fsprogs is still default ;-)

> So changing configure options and using e2fsprogs-1.41.5 that canuse external 
> provided blkid should be enough.
> Is this correct?

 yes, you need

    util-linux-ng 2.15   --with-fsprobe=builtin
    e2fsprogs 1.41.5     --disable-libblkid

   Karel

-- 
 Karel Zak  <kzak@redhat.com>

Re: util-linux-ng required? which version?

[Kay Sievers]

On Mon, May 11, 2009 at 12:23, Karel Zak <kzak@redhat.com> wrote:
> On Mon, May 11, 2009 at 11:50:07AM +0200, Matthias Schwarzott wrote:
>> On Montag, 11. Mai 2009, Matthias Schwarzott wrote:

>> > I have seen, udev-git now removed vol_id and requires blkid from latest
>> > util-linux-ng? What version does "latest" mean?
>> > I have util-linux-2.15 installed, and this is the latest released version
>> > according to its homepage.
>>
>> Ah I guess 2.15 should be fine (according to changelog),

Yeah, there is only a single version so far, of util-linux-ng that
contains libblkid. :)

>> but on gentoo up to
>> now blkid and libblkid is provided by e2fsprogs.

Yep, that needs to be switched around.

>  just note that libblkid from e2fsprogs is still default ;-)

Yeah, but the "default" will not work anymore very soon. :)

>> So changing configure options and using e2fsprogs-1.41.5 that canuse external
>> provided blkid should be enough.
>> Is this correct?
>
>  yes, you need
>
>    util-linux-ng 2.15   --with-fsprobe=builtin
>    e2fsprogs 1.41.5     --disable-libblkid

Sounds good.

It's all a bit of inconvenient at the moment with the
inter-dependencies, but it's great that we will all end up finally
with only a single filesystem-probing lib.

Thanks,
Kay

Re: util-linux-ng required? which version?

[Jürg Billeter]

On Mon, 2009-05-11 at 13:43 +0200, Kay Sievers wrote:
> On Mon, May 11, 2009 at 12:23, Karel Zak <kzak@redhat.com> wrote:
> >  yes, you need
> >
> >    util-linux-ng 2.15   --with-fsprobe=builtin
> >    e2fsprogs 1.41.5     --disable-libblkid
> 
> Sounds good.
> 
> It's all a bit of inconvenient at the moment with the
> inter-dependencies, but it's great that we will all end up finally
> with only a single filesystem-probing lib.

Maybe I'm missing something, but doesn't this introduce a circular
dependency?

e2fsprogs depends on util-linux-ng if built with --disable-libblkid
util-linux-ng depends on e2fsprog for libuuid

If I'm not misunderstanding anything, are there plans to fix this?
Maybe libuuid should be moved to a separate package.

Regards,
Jürg

Re: util-linux-ng required? which version?

[Olaf]

Jürg Billeter wrote:
> On Mon, 2009-05-11 at 13:43 +0200, Kay Sievers wrote:
>   
>> On Mon, May 11, 2009 at 12:23, Karel Zak <kzak@redhat.com> wrote:
>>     
>>>  yes, you need
>>>
>>>    util-linux-ng 2.15   --with-fsprobe=builtin
>>>    e2fsprogs 1.41.5     --disable-libblkid
>>>       
>> Sounds good.
>>
>> It's all a bit of inconvenient at the moment with the
>> inter-dependencies, but it's great that we will all end up finally
>> with only a single filesystem-probing lib.
>>     
>
> Maybe I'm missing something, but doesn't this introduce a circular
> dependency?
>
> e2fsprogs depends on util-linux-ng if built with --disable-libblkid
> util-linux-ng depends on e2fsprog for libuuid
>
> If I'm not misunderstanding anything, are there plans to fix this?
> Maybe libuuid should be moved to a separate package.
>   
I think you are on to something there.

Building util-linux-ng 2.15 using --with-fsprobe=builtin, without having 
previously built e2fsprogs, gives me:

/bin/bash ../../../libtool --tagÌ   --mode=compile gcc -std=gnu99 
-DHAVE_CONFIG_H -I. -I../../..  -include ../../../config.h 
-I../../../include -DLOCALEDIR=\"/tools_i486/share/locale\" 
-I../../../libs/blkid/src  -fsigned-char -g -O2 -MT resolve.lo -MD -MP 
-MF .deps/resolve.Tpo -c -o resolve.lo resolve.c
libtool: compile:  gcc -std=gnu99 -DHAVE_CONFIG_H -I. -I../../.. 
-include ../../../config.h -I../../../include 
-DLOCALEDIR=\"/tools_i486/share/locale\" -I../../../libs/blkid/src 
-fsigned-char -g -O2 -MT read.lo -MD -MP -MF .deps/read.Tpo -c read.c  
-fPIC -DPIC -o .libs/read.o
read.c:28:23: error: uuid/uuid.h: No such file or directory
make[3]: *** [read.lo] Error 1
make[3]: *** Waiting for unfinished jobs....


IIRC uuid.h is provided by e2fsprogs, which is now supposed to be build 
after util-linux-ng

Any ideas?



Olaf

Re: util-linux-ng required? which version?

[Karel Zak]

On Tue, May 12, 2009 at 06:45:51PM +0200, Olaf wrote:
> Jürg Billeter wrote:
>> On Mon, 2009-05-11 at 13:43 +0200, Kay Sievers wrote:
>>   
>>> On Mon, May 11, 2009 at 12:23, Karel Zak <kzak@redhat.com> wrote:
>>>     
>>>>  yes, you need
>>>>
>>>>    util-linux-ng 2.15   --with-fsprobe=builtin
>>>>    e2fsprogs 1.41.5     --disable-libblkid
>>>>       
>>> Sounds good.
>>>
>>> It's all a bit of inconvenient at the moment with the
>>> inter-dependencies, but it's great that we will all end up finally
>>> with only a single filesystem-probing lib.
>>>     
>>
>> Maybe I'm missing something, but doesn't this introduce a circular
>> dependency?
>>
>> e2fsprogs depends on util-linux-ng if built with --disable-libblkid
>> util-linux-ng depends on e2fsprog for libuuid
>>
>> If I'm not misunderstanding anything, are there plans to fix this?
>> Maybe libuuid should be moved to a separate package.

 I'd like to move libuuid also to util-linux-ng. The library is really
 not e2fs-specific and a lot of packages depend on the library. For
 example Fedora 10:

 $ repoquery --whatrequires libuuid* --queryformat="%{NAME}" | sort -u | wc -l
 61

 Ted, any opinion?

> Building util-linux-ng 2.15 using --with-fsprobe=builtin, without having  
> previously built e2fsprogs, gives me:
[...]
> read.c:28:23: error: uuid/uuid.h: No such file or directory
> make[3]: *** [read.lo] Error 1
> make[3]: *** Waiting for unfinished jobs....

 Thanks for your report. Fixed (see below). 
 
 The libuuid should be optional for u-l-ng. BUT it's recommended to
 link mkswap against libuuid, so after e2fsprogs installation you can
 rebuild and reinstall util-linux-ng. For example for RPM it's not a
 problem when A depends on B and B on A. (I hope:-)

    Karel

From cdd17c7a73cab10a34bf80616225b8215ac4e2ed Mon Sep 17 00:00:00 2001
From: Karel Zak <kzak@redhat.com>
Date: Tue, 12 May 2009 21:22:19 +0200
Subject: [PATCH] blkid: make libuuid optional

read.c:28:23: error: uuid/uuid.h: No such file or directory
make[3]: *** [read.lo] Error 1
make[3]: *** Waiting for unfinished jobs....

Reported-by: Olaf <mailinglists@ban-solms.de>
Signed-off-by: Karel Zak <kzak@redhat.com>
---
 libs/blkid/src/config.c   |    3 ---
 libs/blkid/src/evaluate.c |    3 ---
 libs/blkid/src/read.c     |    1 -
 3 files changed, 0 insertions(+), 7 deletions(-)

diff --git a/libs/blkid/src/config.c b/libs/blkid/src/config.c
index 2e59218..9091736 100644
--- a/libs/blkid/src/config.c
+++ b/libs/blkid/src/config.c
@@ -24,9 +24,6 @@
 #include <errno.h>
 #endif
 #include <stdint.h>
-#ifdef HAVE_LIBUUID
-#include <uuid/uuid.h>
-#endif
 #include <stdarg.h>
 
 #include "blkdev.h"
diff --git a/libs/blkid/src/evaluate.c b/libs/blkid/src/evaluate.c
index a9c9fba..f0ae126 100644
--- a/libs/blkid/src/evaluate.c
+++ b/libs/blkid/src/evaluate.c
@@ -27,9 +27,6 @@
 #include <errno.h>
 #endif
 #include <stdint.h>
-#ifdef HAVE_LIBUUID
-#include <uuid/uuid.h>
-#endif
 #include <stdarg.h>
 
 #include "pathnames.h"
diff --git a/libs/blkid/src/read.c b/libs/blkid/src/read.c
index 4163874..b5e9cd0 100644
--- a/libs/blkid/src/read.c
+++ b/libs/blkid/src/read.c
@@ -25,7 +25,6 @@
 #endif
 
 #include "blkidP.h"
-#include "uuid/uuid.h"
 
 #ifdef HAVE_STRTOULL
 #define STRTOULL strtoull /* defined in stdlib.h if you try hard enough */
-- 
1.6.0.6

Re: util-linux-ng required? which version?

[Olaf]

Karel Zak wrote:

>> Building util-linux-ng 2.15 using --with-fsprobe=builtin, without having  
>> previously built e2fsprogs, gives me:
> [...]
>> read.c:28:23: error: uuid/uuid.h: No such file or directory
>> make[3]: *** [read.lo] Error 1
>> make[3]: *** Waiting for unfinished jobs....
> 
>  Thanks for your report. Fixed (see below). 

Builds fine now, thanks Karel!

I think util-linux-ng is missing some kind of make install libblkid?
Otherwise e2fsprogs with --disable-libblkid complains about not being 
able to find external blkid library.

Or am I missing something trivial? (would not be the first time ...)


>  The libuuid should be optional for u-l-ng. BUT it's recommended to
>  link mkswap against libuuid, so after e2fsprogs installation you can
>  rebuild and reinstall util-linux-ng. For example for RPM it's not a
>  problem when A depends on B and B on A. (I hope:-)

Better keep your fingers crossed then ;-)


Olaf

> From cdd17c7a73cab10a34bf80616225b8215ac4e2ed Mon Sep 17 00:00:00 2001
> From: Karel Zak <kzak@redhat.com>
> Date: Tue, 12 May 2009 21:22:19 +0200
> Subject: [PATCH] blkid: make libuuid optional
> 
> read.c:28:23: error: uuid/uuid.h: No such file or directory
> make[3]: *** [read.lo] Error 1
> make[3]: *** Waiting for unfinished jobs....
> 
> Reported-by: Olaf <mailinglists@ban-solms.de>
> Signed-off-by: Karel Zak <kzak@redhat.com>
> ---
>  libs/blkid/src/config.c   |    3 ---
>  libs/blkid/src/evaluate.c |    3 ---
>  libs/blkid/src/read.c     |    1 -
>  3 files changed, 0 insertions(+), 7 deletions(-)
> 
> diff --git a/libs/blkid/src/config.c b/libs/blkid/src/config.c
> index 2e59218..9091736 100644
> --- a/libs/blkid/src/config.c
> +++ b/libs/blkid/src/config.c
> @@ -24,9 +24,6 @@
>  #include <errno.h>
>  #endif
>  #include <stdint.h>
> -#ifdef HAVE_LIBUUID
> -#include <uuid/uuid.h>
> -#endif
>  #include <stdarg.h>
>  
>  #include "blkdev.h"
> diff --git a/libs/blkid/src/evaluate.c b/libs/blkid/src/evaluate.c
> index a9c9fba..f0ae126 100644
> --- a/libs/blkid/src/evaluate.c
> +++ b/libs/blkid/src/evaluate.c
> @@ -27,9 +27,6 @@
>  #include <errno.h>
>  #endif
>  #include <stdint.h>
> -#ifdef HAVE_LIBUUID
> -#include <uuid/uuid.h>
> -#endif
>  #include <stdarg.h>
>  
>  #include "pathnames.h"
> diff --git a/libs/blkid/src/read.c b/libs/blkid/src/read.c
> index 4163874..b5e9cd0 100644
> --- a/libs/blkid/src/read.c
> +++ b/libs/blkid/src/read.c
> @@ -25,7 +25,6 @@
>  #endif
>  
>  #include "blkidP.h"
> -#include "uuid/uuid.h"
>  
>  #ifdef HAVE_STRTOULL
>  #define STRTOULL strtoull /* defined in stdlib.h if you try hard enough */

Re: util-linux-ng required? which version?

[Karel Zak]

On Tue, May 12, 2009 at 10:31:07PM +0200, Olaf wrote:
> Karel Zak wrote:
>
>>> Building util-linux-ng 2.15 using --with-fsprobe=builtin, without 
>>> having  previously built e2fsprogs, gives me:
>> [...]
>>> read.c:28:23: error: uuid/uuid.h: No such file or directory
>>> make[3]: *** [read.lo] Error 1
>>> make[3]: *** Waiting for unfinished jobs....
>>
>>  Thanks for your report. Fixed (see below). 
>
> Builds fine now, thanks Karel!
>
> I think util-linux-ng is missing some kind of make install libblkid?

 $ cd libs/blkid/
 $ make install DESTDIR=/tmp/FOO/
 $ find /tmp/FOO/
 /tmp/FOO/
 /tmp/FOO/lib
 /tmp/FOO/lib/libblkid.so.1
 /tmp/FOO/lib/libblkid.la
 /tmp/FOO/lib/libblkid.so.1.0.0
 /tmp/FOO/lib/libblkid.so
 /tmp/FOO/lib/libblkid.a
 /tmp/FOO/sbin
 /tmp/FOO/sbin/findfs
 /tmp/FOO/sbin/blkid
 /tmp/FOO/sbin/blkid.static
 /tmp/FOO/usr
 /tmp/FOO/usr/include
 /tmp/FOO/usr/include/blkid
 /tmp/FOO/usr/include/blkid/blkid.h
 /tmp/FOO/usr/lib
 /tmp/FOO/usr/lib/pkgconfig
 /tmp/FOO/usr/lib/pkgconfig/blkid.pc
 /tmp/FOO/usr/share
 /tmp/FOO/usr/share/man
 /tmp/FOO/usr/share/man/man8
 /tmp/FOO/usr/share/man/man8/findfs.8
 /tmp/FOO/usr/share/man/man8/blkid.8
 /tmp/FOO/usr/share/man/man3
 /tmp/FOO/usr/share/man/man3/libblkid.3

 (or cd libs/blkid/src if you need to install the library only)

    Karel

-- 
 Karel Zak  <kzak@redhat.com>