From: Alan Jenkins <alan-jenkins@tuffmail.co.uk>
To: linux-hotplug@vger.kernel.org
Subject: Re: rules: avoid traversing parent of every single device?
Date: Fri, 22 May 2009 14:33:36 +0000 [thread overview]
Message-ID: <4A16B7C0.4020300@tuffmail.co.uk> (raw)
In-Reply-To: <4A16B385.7000700@tuffmail.co.uk>
Kay Sievers wrote:
> On Fri, May 22, 2009 at 16:15, Alan Jenkins <alan-jenkins@tuffmail.co.uk> wrote:
>
>> I've been looking at what is responsible for all the path lookup activity in
>> coldplug. On my debian stable system, it looks like every device gets its
>> parent looked up in sysfs. I think this is due to SUBSYSTEMS matches.
>>
>> I see the udev default rules are different, but it looks like they still
>> test for SUBSYSTEMS on every single device:
>>
>> SUBSYSTEMS="scsi", ATTRS{type}="1|8", GROUP="tape"
>> SUBSYSTEMS="scsi", ATTRS{type}="4|5", GROUP="cdrom"
>> SUBSYSTEMS="scsi", ATTRS{type}="0", GROUP="disk"
>>
>>
>> Should we add SUBSYSTEM="scsi_generic" to these three rules?
>>
>
> Sounds good. I think the "tape" will need a match for the actual
> scsi-tape devices too? The real "cdrom" and "disk" devices seems
> covered by explicit rules.
>
Yes, good catch.
next prev parent reply other threads:[~2009-05-22 14:33 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-22 14:15 rules: avoid traversing parent of every single device? Alan Jenkins
2009-05-22 14:26 ` Kay Sievers
2009-05-22 14:33 ` Alan Jenkins [this message]
2009-05-22 14:37 ` Kay Sievers
2009-05-22 14:42 ` Alan Jenkins
2009-05-22 14:47 ` Kay Sievers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A16B7C0.4020300@tuffmail.co.uk \
--to=alan-jenkins@tuffmail.co.uk \
--cc=linux-hotplug@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).