From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alan Jenkins Date: Fri, 22 May 2009 14:33:36 +0000 Subject: Re: rules: avoid traversing parent of every single device? Message-Id: <4A16B7C0.4020300@tuffmail.co.uk> List-Id: References: <4A16B385.7000700@tuffmail.co.uk> In-Reply-To: <4A16B385.7000700@tuffmail.co.uk> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: linux-hotplug@vger.kernel.org Kay Sievers wrote: > On Fri, May 22, 2009 at 16:15, Alan Jenkins wrote: > >> I've been looking at what is responsible for all the path lookup activity in >> coldplug. On my debian stable system, it looks like every device gets its >> parent looked up in sysfs. I think this is due to SUBSYSTEMS matches. >> >> I see the udev default rules are different, but it looks like they still >> test for SUBSYSTEMS on every single device: >> >> SUBSYSTEMS="scsi", ATTRS{type}="1|8", GROUP="tape" >> SUBSYSTEMS="scsi", ATTRS{type}="4|5", GROUP="cdrom" >> SUBSYSTEMS="scsi", ATTRS{type}="0", GROUP="disk" >> >> >> Should we add SUBSYSTEM="scsi_generic" to these three rules? >> > > Sounds good. I think the "tape" will need a match for the actual > scsi-tape devices too? The real "cdrom" and "disk" devices seems > covered by explicit rules. > Yes, good catch.