Re: [PATCH 1/2] udevd: respect the value of TIMEOUT in uevents

[Alan Jenkins <alan-jenkins@tuffmail.co.uk>]

Kay Sievers wrote:
> On Tue, May 26, 2009 at 11:52, Alan Jenkins <alan-jenkins@tuffmail.co.uk> wrote:
>   
>> I believe this is the correct behaviour.  I'm highlighting this change
>> by making it a separate commit (even though the specific code will be
>> removed in the following commit).
>>     
>
>   
>> -       alarm(UDEV_EVENT_TIMEOUT);
>> +       if (udev_device_get_timeout(event->dev) > 0)
>> +               alarm(udev_device_get_timeout(event->dev));
>> +       else
>> +               alarm(UDEV_EVENT_TIMEOUT);
>>     
>
> That's the kernel supplied timeout value used for the firmware loader.
> You really don't want to kill the event when this timeout expires. :)
>
> The event_timeout is what we want, but that comes from the rules and
> is not set at this time in the daemon.
>
> Kay
>   

Ok, I'm glad I kept this separate.  Don't apply patch 2 then :-).  I'll
remove this and resubmit.

Thanks
Alan