From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alan Jenkins Date: Tue, 26 May 2009 10:19:49 +0000 Subject: Re: [PATCH 1/2] udevd: respect the value of TIMEOUT in uevents Message-Id: <4A1BC245.5040309@tuffmail.co.uk> List-Id: References: <4A1BBBE6.4040202@tuffmail.co.uk> In-Reply-To: <4A1BBBE6.4040202@tuffmail.co.uk> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: linux-hotplug@vger.kernel.org Kay Sievers wrote: > On Tue, May 26, 2009 at 11:52, Alan Jenkins wrote: > >> I believe this is the correct behaviour. I'm highlighting this change >> by making it a separate commit (even though the specific code will be >> removed in the following commit). >> > > >> - alarm(UDEV_EVENT_TIMEOUT); >> + if (udev_device_get_timeout(event->dev) > 0) >> + alarm(udev_device_get_timeout(event->dev)); >> + else >> + alarm(UDEV_EVENT_TIMEOUT); >> > > That's the kernel supplied timeout value used for the firmware loader. > You really don't want to kill the event when this timeout expires. :) > > The event_timeout is what we want, but that comes from the rules and > is not set at this time in the daemon. > > Kay > Ok, I'm glad I kept this separate. Don't apply patch 2 then :-). I'll remove this and resubmit. Thanks Alan