From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alan Jenkins Date: Mon, 01 Jun 2009 16:24:46 +0000 Subject: Re: [GIT] Experimental threaded udev Message-Id: <4A2400CE.1040502@tuffmail.co.uk> List-Id: References: <4A1EA138.10400@tuffmail.co.uk> In-Reply-To: <4A1EA138.10400@tuffmail.co.uk> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: linux-hotplug@vger.kernel.org Kay Sievers wrote: > On Mon, Jun 1, 2009 at 13:32, Kay Sievers wrote: > >> On Mon, Jun 1, 2009 at 11:29, Alan Jenkins wrote: >> > > >>> I think this loop should finish when the signal handler sets worker_exit? >>> But maybe you didn't actually install a handler for SIGTERM and it's still >>> being reset to the default action: >>> >> Yeah, it's not handled with worker_exit. Now, it's not reliable to >> kill event processes from something else than the main daemon. The >> worker_exit might be nice for valgrind tests though. >> > > Here is version 2 of the patch, with a few things corrected. > > Thanks, > Kay > Ok. I don't think the signal handler should be doing list traversal, in case it interrupts list manipulation in the main loop. Or perhaps the main loop should only allow signals during ppoll(). Thanks Alan