From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alan Jenkins Date: Wed, 03 Jun 2009 20:10:19 +0000 Subject: Re: [PATCH] rules: avoid reading DRIVER for devices without modalias Message-Id: <4A26D8AB.7050800@tuffmail.co.uk> List-Id: References: <4A268DF5.2030108@tuffmail.co.uk> In-Reply-To: <4A268DF5.2030108@tuffmail.co.uk> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: linux-hotplug@vger.kernel.org Kay Sievers wrote: > On Wed, Jun 3, 2009 at 16:51, Alan Jenkins wrote: > >> DRIVER requires a readlink() in sysfs. The MODALIAS key is provided by >> uevent and requires no additional read. Test MODALIAS first. >> > > Are you sure that makes a difference? We *should* sort the keys while > parsing, and run the cheaper ones before the more expensive ones. At > least that's how it was before the rewrite of the parser, and it > *should* be still the same today. > > Thanks, > Kay > Sorry, I'd forgotten that. You're right it makes no difference.