From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Mierswa Date: Mon, 17 Aug 2009 14:19:51 +0000 Subject: [PATCH] Don't compare a non-existing function with NULL Message-Id: <4A896707.6010507@impulze.org> MIME-Version: 1 Content-Type: multipart/mixed; boundary="------------070101020502010405040609" List-Id: To: linux-hotplug@vger.kernel.org This is a multi-part message in MIME format. --------------070101020502010405040609 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Obviously someone forgot something here or didn't use -ansi. Either way, index is nowhere declared so I assume the current behaviour is to check against the index() function coming from somewhere in the POSIX headers. The comparison doesn't make sense then. Signed-off-by: Daniel Mierswa --- libudev/libudev-queue-private.c | 2 -- 1 files changed, 0 insertions(+), 2 deletions(-) --------------070101020502010405040609 Content-Type: text/x-patch; name="0001-Don-t-compare-a-non-existing-function-with-NULL.patch" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename*0="0001-Don-t-compare-a-non-existing-function-with-NULL.patch" diff --git a/libudev/libudev-queue-private.c b/libudev/libudev-queue-private.c index 0427b65..c8e0150 100644 --- a/libudev/libudev-queue-private.c +++ b/libudev/libudev-queue-private.c @@ -158,8 +158,6 @@ static struct queue_devpaths *build_index(struct udev_queue_export *udev_queue_e return NULL; } devpaths = calloc(1, sizeof(struct queue_devpaths) + (range + 1) * sizeof(long)); - if (index == NULL) - return NULL; devpaths->devpaths_size = range + 1; /* read all records and populate the table */ --------------070101020502010405040609--