[PATCH] hid2hci: Remove superfluous bmAttributes match

[PATCH] hid2hci: Remove superfluous bmAttributes match

[Mario Limonciello]

For the retrigger of the device on remove we were trying to match bmAttributes
of self powered which is unnecessary.
---
 extras/hid2hci/70-hid2hci.rules |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/extras/hid2hci/70-hid2hci.rules b/extras/hid2hci/70-hid2hci.rules
index b332c16..2659877 100644
--- a/extras/hid2hci/70-hid2hci.rules
+++ b/extras/hid2hci/70-hid2hci.rules
@@ -20,7 +20,7 @@ ENV{DEVTYPE}!="usb_device", GOTO="hid2hci_end"
 # Unfortunately the only event seen is the BT device disappearing, so the mouse
 # device needs to be chased down on the USB bus.
 ATTR{bDeviceClass}="e0", ATTR{bDeviceSubClass}="01", ATTR{bDeviceProtocol}="01", \
-  ATTR{idVendor}="413c", ATTR{bmAttributes}="e0", \
+  ATTR{idVendor}="413c", \
   ENV{REMOVE_CMD}="/sbin/udevadm trigger --action=change --subsystem-match=usb --property-match=HID2HCI_SWITCH=1"
 
 # CSR devices
-- 
1.6.3.3

Re: [PATCH] hid2hci: Remove superfluous bmAttributes match

[Kay Sievers]

On Thu, Aug 20, 2009 at 19:23, Mario
Limonciello<Mario_Limonciello@dell.com> wrote:
> For the retrigger of the device on remove we were trying to match bmAttributes
> of self powered which is unnecessary.
> ---
>  extras/hid2hci/70-hid2hci.rules |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/extras/hid2hci/70-hid2hci.rules b/extras/hid2hci/70-hid2hci.rules
> index b332c16..2659877 100644
> --- a/extras/hid2hci/70-hid2hci.rules
> +++ b/extras/hid2hci/70-hid2hci.rules
> @@ -20,7 +20,7 @@ ENV{DEVTYPE}!="usb_device", GOTO="hid2hci_end"
>  # Unfortunately the only event seen is the BT device disappearing, so the mouse
>  # device needs to be chased down on the USB bus.
>  ATTR{bDeviceClass}="e0", ATTR{bDeviceSubClass}="01", ATTR{bDeviceProtocol}="01", \
> -  ATTR{idVendor}="413c", ATTR{bmAttributes}="e0", \
> +  ATTR{idVendor}="413c", \
>   ENV{REMOVE_CMD}="/sbin/udevadm trigger --action=change --subsystem-match=usb --property-match=HID2HCI_SWITCH=1"

We have two of these matches? The other one stays?

Kay

Re: [PATCH] hid2hci: Remove superfluous bmAttributes match

[Mario Limonciello]

[-- Attachment #1: Type: text/plain, Size: 409 bytes --]

Hi Kay:

Kay Sievers wrote:
> On Thu, Aug 20, 2009 at 19:23, Mario
> Limonciello<Mario_Limonciello@dell.com> wrote:
>   
>
> We have two of these matches? The other one stays?
>
> Kay
>   
Yeah, the other one is fine.  This one that comes off the BT interface
is the only troublesome one in my testing.

Thanks,
-- 
Mario Limonciello
*Dell | Linux Engineering*
mario_limonciello@dell.com


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 260 bytes --]

Re: [PATCH] hid2hci: Remove superfluous bmAttributes match

[Kay Sievers]

On Thu, Aug 20, 2009 at 19:36, Mario
Limonciello<mario_limonciello@dell.com> wrote:
> Kay Sievers wrote:
>> On Thu, Aug 20, 2009 at 19:23, Mario Limonciello<Mario_Limonciello@dell.com> wrote:
>>
>> We have two of these matches? The other one stays?
>>
> Yeah, the other one is fine.  This one that comes off the BT interface
> is the only troublesome one in my testing.

Cool. Applied.

Thanks,
Kay