linux-hotplug.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Alan Jenkins <alan-jenkins@tuffmail.co.uk>
To: linux-hotplug@vger.kernel.org
Subject: [PATCH] extras/keymap: fix build (GEN keys.txt)
Date: Thu, 29 Oct 2009 14:27:20 +0000	[thread overview]
Message-ID: <4AE9A648.2090006@tuffmail.co.uk> (raw)

Commit 7d701b0 "Merge keymap building in the top-level Makefile.am"
caused a build failure when extras are enabled.

Specifically, it changed the command used to generate keys.txt in several
ways.  The most obvious change was that the output was completely empty :).
This was probably missed due to stale Makefiles.  Hint: to reproduce the
build failure, first run "make distclean".

Fix the generation of keys.txt by reverting to the original command.

Also add some dependencies on the Makefile.  This means keys.txt will be
rebuilt automatically if the command is changed in future.

Build tested only.  I don't use udev-keymap, so it would a good idea for
someone who does to test it (Diego?) :).

Signed-off-by: Alan Jenkins <alan-jenkins@tuffmail.co.uk>
CC: Diego Elio 'Flameeyes' Pettenò <flameeyes@gmail.com>
---
 Makefile.am |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/Makefile.am b/Makefile.am
index cf7d364..a439157 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -530,10 +530,10 @@ dist_udevkeymap_DATA = \
 	extras/keymap/keymaps/toshiba-satellite_a110 \
 	extras/keymap/keymaps/zepto-znote
 
-extras/keymap/keys.txt: /usr/include/linux/input.h
-	$(AM_V_GEN)$(AWK) '/^#define.*KEY_[^ ]+[[:space:]]+[0-9]/ { if ($$2 != "KEY_MAX") { print $$2 } }' < $< | sed 's/^KEY_COFFEE$$/KEY_SCREENLOCK/' > $@
+extras/keymap/keys.txt: /usr/include/linux/input.h Makefile
+	$(AM_V_GEN)$(AWK) '/^#define.*KEY_/ { if ($$2 != "KEY_MAX" && $$2 != "KEY_CNT") { print $$2 } }' < $< > $@
 
-extras/keymap/keys-from-name.gperf: extras/keymap/keys.txt
+extras/keymap/keys-from-name.gperf: extras/keymap/keys.txt Makefile
 	$(AM_V_GEN)$(AWK) 'BEGIN{ print "struct key { const char* name; unsigned short id; };"; print "%null-strings"; print "%%";} { print $$1 ", " $$1 }' < $< > $@
 
 extras/keymap/keys-from-name.h: extras/keymap/keys-from-name.gperf Makefile
-- 
1.5.6.5




             reply	other threads:[~2009-10-29 14:27 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-10-29 14:27 Alan Jenkins [this message]
2009-10-29 15:03 ` [PATCH] extras/keymap: fix build (GEN keys.txt) Lennart Poettering
2009-10-29 16:01 ` Alan Jenkins
2009-10-29 19:06 ` Martin Pitt
2009-10-29 20:10 ` Alan Jenkins
2009-10-29 20:17 ` 
2009-10-29 20:40 ` Dan Nicholson
2009-10-29 20:46 ` 
2009-10-29 20:56 ` Alan Jenkins
2009-10-30  8:40 ` Martin Pitt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4AE9A648.2090006@tuffmail.co.uk \
    --to=alan-jenkins@tuffmail.co.uk \
    --cc=linux-hotplug@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).