linux-hotplug.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Felix Schwarz <felix.schwarz@oss.schwarz.eu>
To: linux-hotplug@vger.kernel.org
Subject: Retire modem-modeswitch for non-option devices?
Date: Tue, 05 Jan 2010 21:58:44 +0000	[thread overview]
Message-ID: <4B43B614.7070203@oss.schwarz.eu> (raw)

Hi,

I'm trying to add support for my UMTS USB stick (Huawei 3765) to udev. 
Until yesterday I was pretty sure that I need to patch modem-modeswitch 
+ adding some udev rules.

However today I found changeset 8a993fab2f218234f06743bcc127dda61a45711b 
by Dan Williams committed on Nov 23 which basically says that it is 
completely wrong to use 'option-zerocd' for non-option devices.

Dan send a reasoning before doing his revert:
http://www.spinics.net/lists/hotplug/msg03143.html

More specifically he wrote:
"All further modem eject stuff should really handled by usb_modeswitch,
not by modem-modeswitch.  I'll follow up with a patch for the rules file
saying that only Option devices should be added, and that usb_modeswitch
is really the right place for this stuff."

I'm puzzled by that...
1. Does that mean that you (udev upstream) declare modem-modeswitch a
    dead end and everybody should look at usb_modeswitch?
2. If a supposedly wrong string works on real hardware for real users -
    how can it be wrong? You might want to argue that a parameter
    'option-zerocd' is wrong for non-option devices and we should use a
    different name for the parameter...
3. If usb_modeswitch is the way to go, are you comfortable adding this
     as a dependency (by including rules which call usb_modeswitch)?

fs

PS: cc'ing Dan as he's not on the list afaik, cc'ing Martin because he 
commited the original commit and is in charge for the original Ubuntu bug.

             reply	other threads:[~2010-01-05 21:58 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-01-05 21:58 Felix Schwarz [this message]
2010-01-07  2:14 ` Retire modem-modeswitch for non-option devices? Dan Williams

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4B43B614.7070203@oss.schwarz.eu \
    --to=felix.schwarz@oss.schwarz.eu \
    --cc=linux-hotplug@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).