[PATCH] add ACL for color measurement devices

[PATCH] add ACL for color measurement devices

[Frederic Crozat]

[-- Attachment #1: Type: text/plain, Size: 487 bytes --]

Hi,
sftp://fcrozat@kenobi/home/fcrozat/checkout/udev/0001-rules-udev-acl-add-color-measurement-devices.patch
as part of writing udev rules for Argyllcms supported color measurement 
devices, it would be great if udev upstream could merge attached patch 
which set ACL on such devices, when detected using Argyllcms own rules. 
This is similar to what is done in gphoto2 and other packages and allows 
to centralize ACL policy in udev own 70-acl.rules file.

-- 
Frederic Crozat
Mandriva

[-- Attachment #2: 0001-rules-udev-acl-add-color-measurement-devices.patch --]
[-- Type: text/plain, Size: 974 bytes --]

From 403687a4855f8098bdbc7ac72874630b83e11678 Mon Sep 17 00:00:00 2001
From: Frederic Crozat <fcrozat@mandriva.com>
Date: Thu, 14 Jan 2010 15:11:27 +0100
Subject: [PATCH] rules: udev-acl -add color measurement devices

---
 extras/udev-acl/70-acl.rules |    3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)

diff --git a/extras/udev-acl/70-acl.rules b/extras/udev-acl/70-acl.rules
index ab2984c..78e3eba 100644
--- a/extras/udev-acl/70-acl.rules
+++ b/extras/udev-acl/70-acl.rules
@@ -60,6 +60,9 @@ SUBSYSTEM=="input", ENV{ID_INPUT_JOYSTICK}=="?*", ENV{ACL_MANAGE}="1"
 # smart phones
 SUBSYSTEM=="usb", ATTR{idVendor}=="0bb4", ATTR{idProduct}=="0c02", ENV{ACL_MANAGE}="1"
 
+# color measurement devices
+ENV{COLOR_MEASUREMENT_DEVICE}=="*?", ENV{ACL_MANAGE}="1"
+
 # apply ACL for all locally logged in users
 LABEL="acl_apply", ENV{ACL_MANAGE}=="?*", TEST=="/var/run/ConsoleKit/database", \
   RUN+="udev-acl --action=$env{ACTION} --device=$env{DEVNAME}"
-- 
1.6.6

Re: [PATCH] add ACL for color measurement devices

[Marco d'Itri]

On Jan 14, Frederic Crozat <fcrozat@mandriva.com> wrote:

> as part of writing udev rules for Argyllcms supported color measurement  
> devices, it would be great if udev upstream could merge attached patch  
> which set ACL on such devices, when detected using Argyllcms own rules.  
> This is similar to what is done in gphoto2 and other packages and allows  
> to centralize ACL policy in udev own 70-acl.rules file.
I can't see the point. If the device is recognized by rules somewhere
else I see no benefits in setting $ACL_MANAGE in a different file.

-- 
ciao,
Marco

Re: [PATCH] add ACL for color measurement devices

[Kay Sievers]

On Thu, Jan 14, 2010 at 15:37, Frederic Crozat <fcrozat@mandriva.com> wrote:
> sftp://fcrozat@kenobi/home/fcrozat/checkout/udev/0001-rules-udev-acl-add-color-measurement-devices.patch
> as part of writing udev rules for Argyllcms supported color measurement
> devices, it would be great if udev upstream could merge attached patch which
> set ACL on such devices, when detected using Argyllcms own rules. This is
> similar to what is done in gphoto2 and other packages and allows to
> centralize ACL policy in udev own 70-acl.rules file.

Applied.

Thanks,
Kay

Re: [PATCH] add ACL for color measurement devices

[Frederic Crozat]

Le 14/01/2010 16:12, Marco d'Itri a écrit :
> On Jan 14, Frederic Crozat<fcrozat@mandriva.com>  wrote:
>
>> as part of writing udev rules for Argyllcms supported color measurement
>> devices, it would be great if udev upstream could merge attached patch
>> which set ACL on such devices, when detected using Argyllcms own rules.
>> This is similar to what is done in gphoto2 and other packages and allows
>> to centralize ACL policy in udev own 70-acl.rules file.
> I can't see the point. If the device is recognized by rules somewhere
> else I see no benefits in setting $ACL_MANAGE in a different file.

Well, IIRC, it was discussed here some time ago, people arguying it was 
better to "centralize" ACL in 70-acl.rules. This mecanism is already 
used for gphoto, libsane, hplip and so on ;)

-- 
Frederic Crozat
Mandriva