PATCH: minor cleanup patch for udev-095/scsi_id

PATCH: minor cleanup patch for udev-095/scsi_id

[Gurudas Pai]

[-- Attachment #1: Type: text/plain, Size: 229 bytes --]

Hi ,

With udev-095 , when scsi_id fails for "scsi_id -g -u -s /block/ram1"
it leaves behind a temp nod under /dev, following patch adds a unlink 
for this kind of  failure. Please let me know if this makes sense.

Thanks,
-Guru

[-- Attachment #2: cleanup-temp-nod.patch --]
[-- Type: text/x-patch, Size: 472 bytes --]

--- udev-095.orig/extras/scsi_id/scsi_id.c	2010-02-04 00:30:19.000000000 -0800
+++ udev-095/extras/scsi_id/scsi_id.c	2010-02-04 00:30:39.000000000 -0800
@@ -674,6 +674,8 @@ static int scsi_id(const char *devpath, 
 		dev_scsi = sysfs_device_get_parent_with_subsystem(dev, "scsi");
 		if (dev_scsi == NULL) {
 			err("unable to access parent device of '%s'", devpath);
+			if (!dev_specified)
+				unlink(maj_min_dev);				
 			return 1;
 		}
 		set_sysfs_values(dev_scsi);

Re: PATCH: minor cleanup patch for udev-095/scsi_id

[Kay Sievers]

On Thu, Feb 4, 2010 at 08:58, Gurudas Pai <gurudas.pai@oracle.com> wrote:
> With udev-095 , when scsi_id fails for "scsi_id -g -u -s /block/ram1"
> it leaves behind a temp nod under /dev, following patch adds a unlink for
> this kind of  failure. Please let me know if this makes sense.

This code was removed almost two years ago. So this should not be an
issue with the current code.

Thanks,
Kay