From mboxrd@z Thu Jan 1 00:00:00 1970 From: Frederic Crozat Date: Thu, 04 Mar 2010 08:40:58 +0000 Subject: Re: ACL_MANAGE meaning in udev is inconsistent Message-Id: <4B8F721A.2@mandriva.com> List-Id: References: In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit To: linux-hotplug@vger.kernel.org Le 04/03/2010 01:33, Kay Sievers a écrit : > 2010/3/3 Martin Pitt: >> Rafał Rzepecki [2010-02-19 7:37 +0100]: >>> In extras/udev-acl/70-acl.rules:4 ACL_MANAGE is tested for zeroness to check >>> whether a device should be excluded from ACL management: >>> >>> ENV{ACL_MANAGE}="0", GOTO="acl_end" >>> >>> This is not consistent with usage in extras/udev-acl/udev-acl.c:292: >> >> Thanks for catching this! Fixed in >> >> http://git.kernel.org/?p=linux/hotplug/udev.git;a=commitdiff;h\3ebbf35a2c101e0212c7066f0d65e457fcf40c > > I'll remove that later on. Please do not rely on this functionality. > The ACL_MANAGE key must not leak to any other rules file. We will > likely change that name to be able to speed things up, and nothing > should use it outside the acl rules file. Hmm, this is problematic : a lot of rules outside udev are using ACL_MANAGE to specify ACL should be set for some devices. I would suggest to not "deprecate" ACL_MANAGE outside 70-acl.rules but internally to 70-acl.rules, use another variable. -- Frederic Crozat Mandriva