From mboxrd@z Thu Jan 1 00:00:00 1970 From: Harald Hoyer Date: Tue, 06 Apr 2010 12:43:38 +0000 Subject: Re: udev git head: cdrom_id regression Message-Id: <4BBB2C7A.9010200@redhat.com> MIME-Version: 1 Content-Type: multipart/mixed; boundary="------------030208070003000705020101" List-Id: References: <20100406121935.GA1924@piware.de> In-Reply-To: <20100406121935.GA1924@piware.de> To: linux-hotplug@vger.kernel.org This is a multi-part message in MIME format. --------------030208070003000705020101 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Am 06.04.2010 14:26, schrieb Kay Sievers: > On Tue, Apr 6, 2010 at 14:19, Martin Pitt wrote: >> Kay, do you know why [2] was done in the first place? Do you happen to >> have a pointer to a bug etc. which describes the problems with CD >> burning sessions? > > Harald said, he has several bugs with cd burning caused by cdrom_id > and blkid opening the device when a uevent is handled during cd > burning. I did not receive any such bug. > > Kay https://bugzilla.redhat.com/show_bug.cgi?id=481346 https://bugzilla.redhat.com/show_bug.cgi?id=566535 We might want to apply the attached patches. --------------030208070003000705020101 Content-Type: text/plain; name="0001-cdrom_id-remove-debugging-code.patch" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="0001-cdrom_id-remove-debugging-code.patch" RnJvbSAxOTRjNWMxMGI2NTQ5OWU1Mjg2NDEzMmVkNTQyODQ1YjRjMmU3NTdjIE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBIYXJhbGQgSG95ZXIgPGhhcmFsZEByZWRoYXQuY29t PgpEYXRlOiBUdWUsIDYgQXByIDIwMTAgMTQ6MzQ6MzIgKzAyMDAKU3ViamVjdDogW1BBVENI IDEvMl0gY2Ryb21faWQ6IHJlbW92ZSBkZWJ1Z2dpbmcgY29kZQoKLS0tCiBleHRyYXMvY2Ry b21faWQvY2Ryb21faWQuYyB8ICAgIDEgLQogMSBmaWxlcyBjaGFuZ2VkLCAwIGluc2VydGlv bnMoKyksIDEgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvZXh0cmFzL2Nkcm9tX2lkL2Nk cm9tX2lkLmMgYi9leHRyYXMvY2Ryb21faWQvY2Ryb21faWQuYwppbmRleCBlNDg1NzY4Li4w MzZlZjI4IDEwMDY0NAotLS0gYS9leHRyYXMvY2Ryb21faWQvY2Ryb21faWQuYworKysgYi9l eHRyYXMvY2Ryb21faWQvY2Ryb21faWQuYwpAQCAtMTI2LDcgKzEyNiw2IEBAIHN0YXRpYyBp bnQgaXNfbW91bnRlZChjb25zdCBjaGFyICpkZXZpY2UpCiAJaWYgKGZwID09IE5VTEwpCiAJ CXJldHVybiAtRU5PU1lTOwogCXdoaWxlIChmc2NhbmYoZnAsICIlKnMgJSpzICVpOiVpICUq W15cbl0iLCAmbWFqLCAmbWluKSA9PSAyKSB7Ci0JCXByaW50ZigiZ290ICV1ICV1XG4iLCBt YWosIG1pbik7CiAJCWlmIChtYWtlZGV2KG1haiwgbWluKSA9PSBzdGF0YnVmLnN0X3JkZXYp IHsKIAkJCW1vdW50ZWQgPSAxOwogCQkJYnJlYWs7Ci0tIAoxLjYuNi4xCgo= --------------030208070003000705020101 Content-Type: text/plain; name="0002-cdrom_id-retry-to-open-the-device-if-EBUSY.patch" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="0002-cdrom_id-retry-to-open-the-device-if-EBUSY.patch" RnJvbSBjYjNkOTc1MTNmZWM2OWM0Zjc1Y2YyNDY1MWExNjQwNGRkNTc2ZGE0IE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBIYXJhbGQgSG95ZXIgPGhhcmFsZEByZWRoYXQuY29t PgpEYXRlOiBUdWUsIDYgQXByIDIwMTAgMTQ6Mzc6MjEgKzAyMDAKU3ViamVjdDogW1BBVENI IDIvMl0gY2Ryb21faWQ6IHJldHJ5IHRvIG9wZW4gdGhlIGRldmljZSwgaWYgRUJVU1kKCi0t LQogZXh0cmFzL2Nkcm9tX2lkL2Nkcm9tX2lkLmMgfCAgIDI5ICsrKysrKysrKysrKysrKysr KysrKysrLS0tLS0tCiAxIGZpbGVzIGNoYW5nZWQsIDIzIGluc2VydGlvbnMoKyksIDYgZGVs ZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvZXh0cmFzL2Nkcm9tX2lkL2Nkcm9tX2lkLmMgYi9l eHRyYXMvY2Ryb21faWQvY2Ryb21faWQuYwppbmRleCAwMzZlZjI4Li41ZTBkZGJhIDEwMDY0 NAotLS0gYS9leHRyYXMvY2Ryb21faWQvY2Ryb21faWQuYworKysgYi9leHRyYXMvY2Ryb21f aWQvY2Ryb21faWQuYwpAQCAtNTkxLDEyICs1OTEsMjkgQEAgaW50IG1haW4oaW50IGFyZ2Ms IGNoYXIgKmFyZ3ZbXSkKIAkJZ290byBleGl0OwogCX0KIAotCWZkID0gb3Blbihub2RlLCBP X1JET05MWXxPX05PTkJMT0NLfChpc19tb3VudGVkKG5vZGUpID8gMCA6IE9fRVhDTCkpOwot CWlmIChmZCA8IDApIHsKLQkJaW5mbyh1ZGV2LCAidW5hYmxlIHRvIG9wZW4gJyVzJ1xuIiwg bm9kZSk7Ci0JCWZwcmludGYoc3RkZXJyLCAidW5hYmxlIHRvIG9wZW4gJyVzJ1xuIiwgbm9k ZSk7Ci0JCXJjID0gMTsKLQkJZ290byBleGl0OworCisJeworCQlpbnQgZXJybm9fb3Blbj0w OworCQlpbnQgaSA9IDA7CisKKwkJZG8geworCQkJaW50IGV4Y2wgPSBpc19tb3VudGVkKG5v ZGUpID8gMCA6IE9fRVhDTDsKKwkJCWZkID0gb3Blbihub2RlLCBPX1JET05MWXxPX05PTkJM T0NLfGV4Y2wpOworCQkJZXJybm9fb3BlbiA9IGVycm5vOworCQkJaWYgKGZkIDwgMCkgewor CQkJCWlmIChlcnJub19vcGVuICE9IEVCVVNZIHx8IGkgPj0gMTAwKSB7CisJCQkJCWNoYXIg KnN0cmVyciA9IHN0cmVycm9yKGVycm5vX29wZW4pOworCQkJCQlpbmZvKHVkZXYsICJ1bmFi bGUgdG8gb3BlbiAnJXMnOiAlc1xuIiwgbm9kZSwgc3RyZXJyKTsKKwkJCQkJZnByaW50Zihz dGRlcnIsICJ1bmFibGUgdG8gb3BlbiAnJXMnOiAlc1xuIiwgbm9kZSwgc3RyZXJyKTsKKwkJ CQkJcmMgPSAxOworCQkJCQlnb3RvIGV4aXQ7CisJCQkJfSBlbHNlIHsKKwkJCQkJZnByaW50 ZihzdGRlcnIsICJ1bmFibGUgdG8gb3BlbiAnJXMnIGV4Y2x1c2l2ZWx5OiByZXRyeWluZyAo JWQvMTAwKVxuIiwgbm9kZSwgaSk7CisJCQkJCXVzbGVlcCgodXNlY29uZHNfdCkoNDAwMDAw LjAgKyA0MDAwMDAuMCAqIHJhbmQoKSAqIDEuMCAvIChSQU5EX01BWCsxLjApKSk7CisJCQkJ CWkrKzsgCisJCQkJfQorCQkJfQorCQl9IHdoaWxlICgoZmQgPCAwKSAmJiAoZXJybm9fb3Bl biA9PSBFQlVTWSkpOwogCX0KIAlpbmZvKHVkZXYsICJwcm9iaW5nOiAnJXMnXG4iLCBub2Rl KTsKIAotLSAKMS42LjYuMQoK --------------030208070003000705020101--