From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jeff Garzik Date: Tue, 25 May 2010 23:41:59 +0000 Subject: Re: [PATCH #upstream-fixes] libata: disable ATAPI AN by default Message-Id: <4BFC6047.30405@garzik.org> List-Id: References: <20100517225405.GA19825@cpu18.student.cs> <20100518132519.GA19658@elliptictech.com> <20100518162350.GA29594@elliptictech.com> <4BF2D8E8.1040602@kernel.org> <4BF2DC55.5010209@kernel.org> <20100518192300.GA30821@elliptictech.com> <4BF3E64D.2040003@kernel.org> <4BF3E9F2.9050608@kernel.org> In-Reply-To: <4BF3E9F2.9050608@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Tejun Heo Cc: "linux-ide@vger.kernel.org" , Kay Sievers , Nick Bowler , David Zeuthen , linux-hotplug@vger.kernel.org, stable@kernel.org On 05/19/2010 09:38 AM, Tejun Heo wrote: > There are ATAPI devices which raise AN when hit by commands issued by > open(). This leads to infinite loop of AN -> MEDIA_CHANGE uevent -> > udev open() to check media -> AN. > > Both ACS and SerialATA standards don't define in which case ATAPI > devices are supposed to raise or not raise AN. They both list media > insertion event as a possible use case for ATAPI ANs but there is no > clear description of what constitutes such events. As such, it seems > a bit too naive to export ANs directly to userland as MEDIA_CHANGE > events without further verification (which should behave similarly to > windows as it apparently is the only thing that some hardware vendors > are testing against). > > This patch adds libata.atapi_an module parameter and disables ATAPI AN > by default for now. > > Signed-off-by: Tejun Heo > Cc: Kay Sievers > Cc: Nick Bowler > Cc: David Zeuthen > Cc: stable@kernel.org > --- > drivers/ata/libata-core.c | 7 ++++++- > 1 file changed, 6 insertions(+), 1 deletion(-) applied