configure patch for cross compilation

configure patch for cross compilation

[Paul Bender]

[-- Attachment #1: Type: text/plain, Size: 418 bytes --]

The message asking about cross compilation reminded me that I have a 
patch that is needed for cross compilation. Because autoconf's 
AC_CHECK_FILE fails when cross compiling, it use in location the pci.ids 
file needs to be surrounded in a conditional. Otherwise, the configure 
script never allows the --with-pci-ids-path to be used.

The patch adds informational messages related to checking for the 
pci.ids file.

[-- Attachment #2: udev-157-pci_ids_path.patch.gz --]
[-- Type: application/gzip, Size: 604 bytes --]

Re: configure patch for cross compilation

[Kay Sievers]

On Wed, Jun 2, 2010 at 16:26, Paul Bender <pebender@san.rr.com> wrote:
> The message asking about cross compilation reminded me that I have a patch
> that is needed for cross compilation. Because autoconf's AC_CHECK_FILE fails
> when cross compiling, it use in location the pci.ids file needs to be
> surrounded in a conditional. Otherwise, the configure script never allows
> the --with-pci-ids-path to be used.

Why would that fail? There are 3 test in a row, two of them are
expected to always fail. If all of them will fail, if you must specify
the thing on the commandline. That seems to work fine here.

And please never send compressed patches, especially not when the
patch is 2 kb in size. :)

Kay

Re: configure patch for cross compilation

[Paul Bender]

On 6/2/2010 7:57 AM, Kay Sievers wrote:
> On Wed, Jun 2, 2010 at 16:26, Paul Bender<pebender@san.rr.com>  wrote:
>> The message asking about cross compilation reminded me that I have a patch
>> that is needed for cross compilation. Because autoconf's AC_CHECK_FILE fails
>> when cross compiling, it use in location the pci.ids file needs to be
>> surrounded in a conditional. Otherwise, the configure script never allows
>> the --with-pci-ids-path to be used.
>
> Why would that fail? There are 3 test in a row, two of them are
> expected to always fail. If all of them will fail, if you must specify
> the thing on the commandline. That seems to work fine here.

I should not have used the term 'fail'. Rather, I should have used the 
term 'die'. The AC_CHECK_FILE macro checks to see whether or not the 
package is being cross compiled. If it is, then then it dies, causing 
the configure script to stop.

> And please never send compressed patches, especially not when the
> patch is 2 kb in size. :)

No problem, I will try to remember in the future. Some mailing lists 
prefer compressing patches because of the mangling that some mail list 
archiving software does to text attachments. I have trouble keeping 
track of which list prefers which format.

Re: configure patch for cross compilation

[Kay Sievers]

On Wed, Jun 2, 2010 at 17:09, Paul Bender <pebender@san.rr.com> wrote:
> On 6/2/2010 7:57 AM, Kay Sievers wrote:
>>> when cross compiling, it use in location the pci.ids file needs to be
>>> surrounded in a conditional. Otherwise, the configure script never allows
>>> the --with-pci-ids-path to be used.
>>
>> Why would that fail? There are 3 test in a row, two of them are
>> expected to always fail. If all of them will fail, if you must specify
>> the thing on the commandline. That seems to work fine here.
>
> I should not have used the term 'fail'. Rather, I should have used the term
> 'die'. The AC_CHECK_FILE macro checks to see whether or not the package is
> being cross compiled. If it is, then then it dies, causing the configure
> script to stop.

Ah, great. It's a feature. :)

Applied. Thanks,
Kay