[PATCH v2] udev: add rules for qemu guests

[PATCH v2] udev: add rules for qemu guests

[Gerd Hoffmann]

These patches enable usb autosuspend for the qemu emulated HID devices.
This reduces the cpu load for idle guests with a hid device attached
because the linux kernel will suspend the usb bus then and qemu can stop
running a 1000 Hz to emulate the (active) UHCI controller.

Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
---
 Makefile.am                       |    5 +++++
 extras/qemu/42-qemu-usb.rules     |   13 +++++++++++++
 rules/misc/30-kernel-compat.rules |    5 +++++
 3 files changed, 23 insertions(+), 0 deletions(-)
 create mode 100644 extras/qemu/42-qemu-usb.rules

diff --git a/Makefile.am b/Makefile.am
index 2e3fe39..b2300ce 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -317,6 +317,11 @@ extras_v4l_id_v4l_id_LDADD = libudev/libudev-private.la
 libexec_PROGRAMS += extras/v4l_id/v4l_id
 dist_udevrules_DATA += extras/v4l_id/60-persistent-v4l.rules
 
+# ------------------------------------------------------------------------------
+# qemu -- qemu/kvm guest tweaks
+# ------------------------------------------------------------------------------
+dist_udevrules_DATA += extras/qemu/99-qemu-usb.rules
+
 if ENABLE_EXTRAS
 # ------------------------------------------------------------------------------
 # conditional extras (need glib, libusb, libacl, ...)
diff --git a/extras/qemu/42-qemu-usb.rules b/extras/qemu/42-qemu-usb.rules
new file mode 100644
index 0000000..4fd53c7
--- /dev/null
+++ b/extras/qemu/42-qemu-usb.rules
@@ -0,0 +1,13 @@
+#
+# Enable autosuspend for qemu emulated usb hid devices.
+#
+# Note that there are buggy qemu versions which advertise remote
+# wakeup support but don't actually implement it correctly.  This
+# is the reason why we need a match for the serial number here.
+# The serial number "42" is used to tag the implementations where
+# remote wakeup is working.
+#
+
+ACTION="add", SUBSYSTEM="usb", ATTR{product}="QEMU USB Mouse", ATTR{serial}="42", TEST="power/control", ATTR{power/control}="auto"
+ACTION="add", SUBSYSTEM="usb", ATTR{product}="QEMU USB Tablet", ATTR{serial}="42", TEST="power/control", ATTR{power/control}="auto"
+CTION="add", SUBSYSTEM="usb", ATTR{product}="QEMU USB Keyboard", ATTR{serial}="42", TEST="power/control", ATTR{power/control}="auto"
diff --git a/rules/misc/30-kernel-compat.rules b/rules/misc/30-kernel-compat.rules
index 2c545dc..2a6a97c 100644
--- a/rules/misc/30-kernel-compat.rules
+++ b/rules/misc/30-kernel-compat.rules
@@ -97,4 +97,9 @@ SUBSYSTEM="mmc", RUN+="/sbin/modprobe -b mmc_block"
 SUBSYSTEM="pnp", DRIVER!="?*", \
   RUN{ignore_error}+="/bin/sh -c '/sbin/modprobe -a $$(while read id; do echo pnp:d$$id; done < /sys$devpath/id)'"
 
+# see extras/qemu/42-qemu-usb.rules, version for 2.6.32 + older.
+ACTION="add", SUBSYSTEM="usb", ATTR{product}="QEMU USB Mouse", ATTR{serial}="42", TEST="power/level", ATTR{power/level}="auto"
+ACTION="add", SUBSYSTEM="usb", ATTR{product}="QEMU USB Tablet", ATTR{serial}="42", TEST="power/level", ATTR{power/level}="auto"
+ACTION="add", SUBSYSTEM="usb", ATTR{product}="QEMU USB Keyboard", ATTR{serial}="42", TEST="power/level", ATTR{power/level}="auto"
+
 LABEL="kernel_compat_end"
-- 
1.7.1

Re: [PATCH v2] udev: add rules for qemu guests

[Kay Sievers]

On Tue, Jan 25, 2011 at 15:51, Gerd Hoffmann <kraxel@redhat.com> wrote:
> These patches enable usb autosuspend for the qemu emulated HID devices.
> This reduces the cpu load for idle guests with a hid device attached
> because the linux kernel will suspend the usb bus then and qemu can stop
> running a 1000 Hz to emulate the (active) UHCI controller.

Applied.

Thanks,
Kay

Re: [PATCH v2] udev: add rules for qemu guests

[Ozan Çağlayan]

On 25.01.2011 16:51, Gerd Hoffmann wrote:

> +ACTION="add", SUBSYSTEM="usb", ATTR{product}="QEMU USB Mouse", ATTR{serial}="42", TEST="power/control", ATTR{power/control}="auto"
> +ACTION="add", SUBSYSTEM="usb", ATTR{product}="QEMU USB Tablet", ATTR{serial}="42", TEST="power/control", ATTR{power/control}="auto"
> +CTION="add", SUBSYSTEM="usb", ATTR{product}="QEMU USB Keyboard", ATTR{serial}="42", TEST="power/control", ATTR{power/control}="auto"

There's a typo in here.


-- 
Pardus Linux
http://www.pardus.org.tr/eng

Re: [PATCH v2] udev: add rules for qemu guests

[Kay Sievers]

On Tue, Jan 25, 2011 at 19:43, Ozan Çağlayan <ozan@pardus.org.tr> wrote:
> On 25.01.2011 16:51, Gerd Hoffmann wrote:
>
>> +ACTION="add", SUBSYSTEM="usb", ATTR{product}="QEMU USB Mouse",
>> ATTR{serial}="42", TEST="power/control", ATTR{power/control}="auto"
>> +ACTION="add", SUBSYSTEM="usb", ATTR{product}="QEMU USB Tablet",
>> ATTR{serial}="42", TEST="power/control", ATTR{power/control}="auto"
>> +CTION="add", SUBSYSTEM="usb", ATTR{product}="QEMU USB Keyboard",
>> ATTR{serial}="42", TEST="power/control", ATTR{power/control}="auto"
>
> There's a typo in here.

Fixed.

Thanks,
Kay

Re: [PATCH v2] udev: add rules for qemu guests

[Jim Paris]

Gerd Hoffmann wrote:
> These patches enable usb autosuspend for the qemu emulated HID devices.
> This reduces the cpu load for idle guests with a hid device attached
> because the linux kernel will suspend the usb bus then and qemu can stop
> running a 1000 Hz to emulate the (active) UHCI controller.
> 
> Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
> ---
>  Makefile.am                       |    5 +++++
>  extras/qemu/42-qemu-usb.rules     |   13 +++++++++++++
>  rules/misc/30-kernel-compat.rules |    5 +++++
>  3 files changed, 23 insertions(+), 0 deletions(-)
>  create mode 100644 extras/qemu/42-qemu-usb.rules
> 
> diff --git a/Makefile.am b/Makefile.am
> index 2e3fe39..b2300ce 100644
> --- a/Makefile.am
> +++ b/Makefile.am
> @@ -317,6 +317,11 @@ extras_v4l_id_v4l_id_LDADD = libudev/libudev-private.la
>  libexec_PROGRAMS += extras/v4l_id/v4l_id
>  dist_udevrules_DATA += extras/v4l_id/60-persistent-v4l.rules
>  
> +# ------------------------------------------------------------------------------
> +# qemu -- qemu/kvm guest tweaks
> +# ------------------------------------------------------------------------------
> +dist_udevrules_DATA += extras/qemu/99-qemu-usb.rules

That should be 42-qemu-usb.rules

-jim

> +
>  if ENABLE_EXTRAS
>  # ------------------------------------------------------------------------------
>  # conditional extras (need glib, libusb, libacl, ...)
> diff --git a/extras/qemu/42-qemu-usb.rules b/extras/qemu/42-qemu-usb.rules
> new file mode 100644
> index 0000000..4fd53c7
> --- /dev/null
> +++ b/extras/qemu/42-qemu-usb.rules
> @@ -0,0 +1,13 @@
> +#
> +# Enable autosuspend for qemu emulated usb hid devices.
> +#
> +# Note that there are buggy qemu versions which advertise remote
> +# wakeup support but don't actually implement it correctly.  This
> +# is the reason why we need a match for the serial number here.
> +# The serial number "42" is used to tag the implementations where
> +# remote wakeup is working.
> +#
> +
> +ACTION="add", SUBSYSTEM="usb", ATTR{product}="QEMU USB Mouse", ATTR{serial}="42", TEST="power/control", ATTR{power/control}="auto"
> +ACTION="add", SUBSYSTEM="usb", ATTR{product}="QEMU USB Tablet", ATTR{serial}="42", TEST="power/control", ATTR{power/control}="auto"
> +CTION="add", SUBSYSTEM="usb", ATTR{product}="QEMU USB Keyboard", ATTR{serial}="42", TEST="power/control", ATTR{power/control}="auto"
> diff --git a/rules/misc/30-kernel-compat.rules b/rules/misc/30-kernel-compat.rules
> index 2c545dc..2a6a97c 100644
> --- a/rules/misc/30-kernel-compat.rules
> +++ b/rules/misc/30-kernel-compat.rules
> @@ -97,4 +97,9 @@ SUBSYSTEM="mmc", RUN+="/sbin/modprobe -b mmc_block"
>  SUBSYSTEM="pnp", DRIVER!="?*", \
>    RUN{ignore_error}+="/bin/sh -c '/sbin/modprobe -a $$(while read id; do echo pnp:d$$id; done < /sys$devpath/id)'"
>  
> +# see extras/qemu/42-qemu-usb.rules, version for 2.6.32 + older.
> +ACTION="add", SUBSYSTEM="usb", ATTR{product}="QEMU USB Mouse", ATTR{serial}="42", TEST="power/level", ATTR{power/level}="auto"
> +ACTION="add", SUBSYSTEM="usb", ATTR{product}="QEMU USB Tablet", ATTR{serial}="42", TEST="power/level", ATTR{power/level}="auto"
> +ACTION="add", SUBSYSTEM="usb", ATTR{product}="QEMU USB Keyboard", ATTR{serial}="42", TEST="power/level", ATTR{power/level}="auto"
> +
>  LABEL="kernel_compat_end"
> -- 
> 1.7.1
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-hotplug" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html