From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kei Tokunaga Date: Tue, 15 Feb 2011 09:59:24 +0000 Subject: [PATCH] udevadm: update prev properly Message-Id: <4D5A4E7C.3050207@jp.fujitsu.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable To: linux-hotplug@vger.kernel.org Hi, When I tried to boot a system with 256 disks x 4 paths with=20 device-mapper, udevadm trigger (--type=DEvices) that was called from start_udev ended up dumping a core due to a segmentation fault. In udev_enumerate_get_list_entry(), if it finds the devices that=20 should be delayed, it calls syspath_add(). If realloc() in=20 syspath_add() allocates the required memory at a different memory address, referring prev->len afterward causes the segmentation fault. I think something like this patch may be needed. Signed-off-by: Kei Tokunaga --- udev-166-kei/libudev/libudev-enumerate.c | 3 +++ 1 file changed, 3 insertions(+) diff -puN libudev/libudev-enumerate.c~fix-prev-segfault libudev/libudev-enu= merate.c --- udev-166/libudev/libudev-enumerate.c~fix-prev-segfault 2011-02-15 13:40= :23.000000000 +0900 +++ udev-166-kei/libudev/libudev-enumerate.c 2011-02-15 13:40:23.000000000 = +0900 @@ -274,6 +274,9 @@ struct udev_list_entry *udev_enumerate_g /* skip to be delayed devices, and add them to the end of the list */ if (devices_delay_end(udev_enumerate->udev, entry->syspath)) { syspath_add(udev_enumerate, entry->syspath); + /* need to update prev here for the case realloc() gives + a different address */ + prev =3D &udev_enumerate->devices[i]; continue; } =20 _