From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Egerer Date: Fri, 04 Mar 2011 16:06:36 +0000 Subject: Re: [PATCH 0/2] libudev: Get all sysfs attrs for a device Message-Id: <4D710E0C.4010006@secunet.com> List-Id: References: <4D6F5CA6.2010905@secunet.com> In-Reply-To: <4D6F5CA6.2010905@secunet.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: linux-hotplug@vger.kernel.org Kay Sievers schrobtete: > On Thu, Mar 3, 2011 at 18:38, Thomas Egerer wrote: >> The approach shown in the patch may have indeed a performance impact which we >> understand must be avoided. But I take it you are not generally opposed to >> providing such an interface, assuming it is implemented in a way that does not >> interfere with the existing mode of operation? > > Sure, sounds fine to have that. > > Maybe just use the interface for: > udevadm info -a > and replace: > http://git.kernel.org/?p=linux/hotplug/udev.git;a=blob;f=udev/udevadm-info.c;hE10f4aa907dc56a22544564ec1e10045046bf61;hb=HEAD#l34 In regard to your objection concerning performance, I rewrote the original patch, using a separate list for the means of retrieving all sysfs attributes. The newly introduced interface is now being used in udevadm, too. Patches (not linewrapped, this time) follow. Cheers, Thomas