From: Darren Salt <linux@youmustbejoking.demon.co.uk>
To: linux-hotplug@vger.kernel.org
Subject: Re: [PATCH] fix LINK_ZERO parsing in cdsymlinks.c
Date: Thu, 08 Sep 2005 01:41:28 +0000 [thread overview]
Message-ID: <4DA6F05044%linux@youmustbejoking.demon.co.uk> (raw)
In-Reply-To: <m364tea44g.fsf@dynamo.mandriva.com>
I demand that Greg KH may or may not have written...
> On Tue, Sep 06, 2005 at 06:45:42PM +0100, Darren Salt wrote:
>> I demand that Olivier Blin may or may not have written...
>>> The following patch from J.A. Magallon fixes LINK_ZERO parsing in
>>> cdsymlinks.c
>> Good catch...
>> I'm attaching that patch *uncompressed* and with appropriate adjustments
>> to the comments at the start of the file.
> This file is obsoleted by the cdrom_id program. Mind if we just delete the
> cdsymlinks stuff from the udev tree as it isn't needed anymore?
I'd prefer to have them log some "obsoleted, will be removed in version xxx"
messages for a couple of releases. (Output on stderr?)
BTW, I'm not sure that the behaviour of cdrom_id and its associated rules
concerning links for a device for which symlinks already exists is right;
although, as it stands, it'll only be a problem if udev gets duplicate events
(or /dev isn't a tmpfs mount or similar).
--
| Darren Salt | d youmustbejoking,demon,co,uk | nr. Ashington,
| Debian, | s zap,tartarus,org | Northumberland
| RISC OS | @ | Toon Army
| <URL:http://www.youmustbejoking.demon.co.uk/progs.packages.html>
Captain, permission to hook up blender attachments to Mr Spock.
-------------------------------------------------------
SF.Net email is Sponsored by the Better Software Conference & EXPO
September 19-22, 2005 * San Francisco, CA * Development Lifecycle Practices
Agile & Plan-Driven Development * Managing Projects & Teams * Testing & QA
Security * Process Improvement & Measurement * http://www.sqe.com/bsce5sf
_______________________________________________
Linux-hotplug-devel mailing list http://linux-hotplug.sourceforge.net
Linux-hotplug-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-hotplug-devel
next prev parent reply other threads:[~2005-09-08 1:41 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-09-06 10:21 [PATCH] fix LINK_ZERO parsing in cdsymlinks.c Olivier Blin
2005-09-06 17:45 ` Darren Salt
2005-09-07 20:44 ` Greg KH
2005-09-08 1:41 ` Darren Salt [this message]
2005-09-08 2:55 ` Kay Sievers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DA6F05044%linux@youmustbejoking.demon.co.uk \
--to=linux@youmustbejoking.demon.co.uk \
--cc=linux-hotplug@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).