From mboxrd@z Thu Jan 1 00:00:00 1970 From: Darren Salt Date: Thu, 08 Sep 2005 01:41:28 +0000 Subject: Re: [PATCH] fix LINK_ZERO parsing in cdsymlinks.c Message-Id: <4DA6F05044%linux@youmustbejoking.demon.co.uk> List-Id: References: In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: linux-hotplug@vger.kernel.org I demand that Greg KH may or may not have written... > On Tue, Sep 06, 2005 at 06:45:42PM +0100, Darren Salt wrote: >> I demand that Olivier Blin may or may not have written... >>> The following patch from J.A. Magallon fixes LINK_ZERO parsing in >>> cdsymlinks.c >> Good catch... >> I'm attaching that patch *uncompressed* and with appropriate adjustments >> to the comments at the start of the file. > This file is obsoleted by the cdrom_id program. Mind if we just delete the > cdsymlinks stuff from the udev tree as it isn't needed anymore? I'd prefer to have them log some "obsoleted, will be removed in version xxx" messages for a couple of releases. (Output on stderr?) BTW, I'm not sure that the behaviour of cdrom_id and its associated rules concerning links for a device for which symlinks already exists is right; although, as it stands, it'll only be a problem if udev gets duplicate events (or /dev isn't a tmpfs mount or similar). -- | Darren Salt | d youmustbejoking,demon,co,uk | nr. Ashington, | Debian, | s zap,tartarus,org | Northumberland | RISC OS | @ | Toon Army | Captain, permission to hook up blender attachments to Mr Spock. ------------------------------------------------------- SF.Net email is Sponsored by the Better Software Conference & EXPO September 19-22, 2005 * San Francisco, CA * Development Lifecycle Practices Agile & Plan-Driven Development * Managing Projects & Teams * Testing & QA Security * Process Improvement & Measurement * http://www.sqe.com/bsce5sf _______________________________________________ Linux-hotplug-devel mailing list http://linux-hotplug.sourceforge.net Linux-hotplug-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-hotplug-devel