From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bryan Kadzban Date: Mon, 30 Jan 2012 03:49:40 +0000 Subject: Re: [PATCH] Fix default firmware search paths Message-Id: <4F261354.1010908@kadzban.is-a-geek.net> List-Id: References: <4F260A3C.6090309@kadzban.is-a-geek.net> In-Reply-To: <4F260A3C.6090309@kadzban.is-a-geek.net> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: linux-hotplug@vger.kernel.org Kay Sievers wrote: > On Mon, Jan 30, 2012 at 04:10, Bryan Kadzban > wrote: >> "./configure --help" says the default firmware search path >> (--with-firmware-path) is /lib/firmware/updates:/lib/firmware. But the >> actual default is: >> >> [with_firmware_path="$rootprefix/lib/firmware/updates:$rootprefix/lib/firmware"] >> >> and $rootprefix defaults to $ac_default_prefix, which is /usr, not the >> empty string. >> >> Fix this by changing the default with_firmware_path to explicitly match >> the directories the kernel uses to install firmware. >> >> (An alternative fix would be to change the help string for >> --with-firmware-path to mention ${rootprefix}, although I think it'd be >> a good idea to mention that flag's default of /usr as well, if this is >> done.) > > With rootprefix = prefix = /usr, everything is in /usr, also the > kernel package is changed to install the stuff in /usr, and no longer > in /lib. The confusing thing to me is that the kernel source tree, when I "make modules_install" (or firmware_install) dumps the files in /lib/firmware, not under /usr. (Verified just now with 3.2.2 and a couple modules that provide external firmware files: e100 / snd-ymfpci.) On the other hand, I might have set something in the kernel config to make it do that. Didn't notice it, but that doesn't mean much. :-/ > I'll change the help text. That works too. Thanks!