From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jens Axboe Date: Sat, 12 Jul 2014 12:32:01 +0000 Subject: Re: [RFC Patch V1 01/30] mm, kernel: Use cpu_to_mem()/numa_mem_id() to support memoryless node Message-Id: <53C12AC1.4010002@kernel.dk> List-Id: References: <1405064267-11678-1-git-send-email-jiang.liu@linux.intel.com> <1405064267-11678-2-git-send-email-jiang.liu@linux.intel.com> In-Reply-To: <1405064267-11678-2-git-send-email-jiang.liu@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Jiang Liu , Andrew Morton , Mel Gorman , David Rientjes , Mike Galbraith , Peter Zijlstra , "Rafael J . Wysocki" , Dipankar Sarma , "Paul E. McKenney" , Balbir Singh , Thomas Gleixner , Frederic Weisbecker , Jan Kara , Ingo Molnar , Christoph Hellwig , "Srivatsa S. Bhat" , Roman Gushchin , Xie XiuQi Cc: Tony Luck , linux-mm@kvack.org, linux-hotplug@vger.kernel.org, linux-kernel@vger.kernel.org On 2014-07-11 09:37, Jiang Liu wrote: > When CONFIG_HAVE_MEMORYLESS_NODES is enabled, cpu_to_node()/numa_node_id() > may return a node without memory, and later cause system failure/panic > when calling kmalloc_node() and friends with returned node id. > So use cpu_to_mem()/numa_mem_id() instead to get the nearest node with > memory for the/current cpu. > > If CONFIG_HAVE_MEMORYLESS_NODES is disabled, cpu_to_mem()/numa_mem_id() > is the same as cpu_to_node()/numa_node_id(). I think blk-mq requires some of the same help, as do other places in the block layer. I'll take a look at that. As for you smp.c bits here: Acked-by: Jens Axboe -- Jens Axboe