From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jiang Liu Date: Wed, 23 Jul 2014 03:16:53 +0000 Subject: Re: [RFC Patch V1 07/30] mm: Use cpu_to_mem()/numa_mem_id() to support memoryless node Message-Id: <53CF2925.3030803@linux.intel.com> List-Id: References: <1405064267-11678-1-git-send-email-jiang.liu@linux.intel.com> <1405064267-11678-8-git-send-email-jiang.liu@linux.intel.com> <20140711144205.GA27706@htj.dyndns.org> <20140711152156.GB29137@htj.dyndns.org> <20140711160152.GC30865@htj.dyndns.org> <20140711162451.GD30865@htj.dyndns.org> <20140711182814.GE30865@htj.dyndns.org> In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Christoph Lameter , Tejun Heo Cc: Andrew Morton , Mel Gorman , David Rientjes , Mike Galbraith , Peter Zijlstra , "Rafael J . Wysocki" , Vladimir Davydov , Johannes Weiner , "Kirill A. Shutemov" , Rik van Riel , Wanpeng Li , Zhang Yanfei , Catalin Marinas , Jianyu Zhan , malc , Joonsoo Kim , Fabian Frederick , Tony Luck , linux-mm@kvack.org, linux-hotplug@vger.kernel.org, linux-kernel@vger.kernel.org Hi Tejun and Christoph, Thanks for your suggestions and discussion. Tejun really gives a good point to hide memoryless node interface from normal slab users. I will rework the patch set to go that direction. Regards! Gerry On 2014/7/12 3:11, Christoph Lameter wrote: > On Fri, 11 Jul 2014, Tejun Heo wrote: > >> On Fri, Jul 11, 2014 at 12:29:30PM -0500, Christoph Lameter wrote: >>> GFP_THISNODE is mostly used by allocators that need memory from specific >>> nodes. The use of numa_mem_id() there is useful because one will not >>> get any memory at all when attempting to allocate from a memoryless >>> node using GFP_THISNODE. >> >> As long as it's in allocator proper, it doesn't matter all that much >> but the changes are clearly not contained, are they? > > Well there is a proliferation of memory allocators recently. NUMA is often > a second thought in those. >