From mboxrd@z Thu Jan  1 00:00:00 1970
From: Yijing Wang <wangyijing@huawei.com>
Date: Mon, 15 Sep 2014 02:25:04 +0000
Subject: Re: [Patch Part3 V5 6/8] iommu/vt-d: Enhance error recovery in function intel_enable_irq_remapping()
Message-Id: <54164E00.6080109@huawei.com>
List-Id: <linux-hotplug.vger.kernel.org>
References: <1410487848-6027-1-git-send-email-jiang.liu@linux.intel.com> <1410487848-6027-7-git-send-email-jiang.liu@linux.intel.com>
In-Reply-To: <1410487848-6027-7-git-send-email-jiang.liu@linux.intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: Jiang Liu <jiang.liu@linux.intel.com>, Joerg Roedel <joro@8bytes.org>, David Woodhouse <dwmw2@infradead.org>, Yinghai Lu <yinghai@kernel.org>, Bjorn Helgaas <bhelgaas@google.com>, Dan Williams <dan.j.williams@intel.com>, Vinod Koul <vinod.koul@intel.com>, "Rafael J . Wysocki" <rafael.j.wysocki@intel.com>
Cc: Ashok Raj <ashok.raj@intel.com>, Tony Luck <tony.luck@intel.com>, iommu@lists.linux-foundation.org, linux-pci@vger.kernel.org, linux-hotplug@vger.kernel.org, linux-kernel@vger.kernel.org, dmaengine@vger.kernel.org

On 2014/9/12 10:10, Jiang Liu wrote:
> Enhance error recovery in function intel_enable_irq_remapping()
> by tearing down all created data structures.
> 
> Signed-off-by: Jiang Liu <jiang.liu@linux.intel.com>
> ---
>  drivers/iommu/intel_irq_remapping.c |    8 +++++---
>  1 file changed, 5 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/iommu/intel_irq_remapping.c b/drivers/iommu/intel_irq_remapping.c
> index 7cf31a29f77a..81f110aae6df 100644
> --- a/drivers/iommu/intel_irq_remapping.c
> +++ b/drivers/iommu/intel_irq_remapping.c
> @@ -701,9 +701,11 @@ static int __init intel_enable_irq_remapping(void)
>  	return eim ? IRQ_REMAP_X2APIC_MODE : IRQ_REMAP_XAPIC_MODE;
>  
>  error:
> -	/*
> -	 * handle error condition gracefully here!
> -	 */
> +	for_each_iommu(iommu, drhd)
> +		if (ecap_ir_support(iommu->ecap)) {
> +			iommu_disable_irq_remapping(iommu);
> +			intel_teardown_irq_remapping(iommu);
> +		}
>  
>  	if (x2apic_present)
>  		pr_warn("Failed to enable irq remapping.  You are vulnerable to irq-injection attacks.\n");

Reviewed-by: Yijing Wang <wangyijing@huawei.com>


> 


-- 
Thanks!
Yijing