From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Allexio Ju" Date: Tue, 23 Jan 2007 03:27:19 +0000 Subject: Re: Questions on PCI express AER support in HBA driver Message-Id: List-Id: References: In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable To: linux-hotplug@vger.kernel.org Hi, On 1/22/07, Zhang, Yanmin wrote: > 1) pcie_port_service_driver is service driver of port, not end-point devi= ces. > SCSI LLD driver should be end-point devices, so you needn't use reset_link > in pcie_port_service_driver. Great. Thank you for clarification. > 2) (*link_reset) in pci_error_handler structure was obsolete. Pls. don't = use it > at all. Originally, this callback was to tell driver that a pci express l= ink was > reset. Its problem is error_detected might return PCI_ERS_RESULT_NEED_RES= ET also > which means next recovery step is slot_reset. In addition, I want to keep= the > error recovery steps simple, so driver developers are happy to add callba= cks in > drivers. Another reason is the specific driver should be compatible for p= ci and > pci-express together. If we use link_reset in pci_error_handler, the code= s might > be not compatible. Understood and it make sense. Thank you for detail description. > Typically, the callbacks in pci-e (or just pci) drivers could be: > 1) pci_ers_result_t (*error_detected)(struct pci_dev *dev, > enum pci_channel_state error); > 2) pci_ers_result_t (*slot_reset)(struct pci_dev *dev); > 3) void (*resume)(struct pci_dev *dev); Understood. Thank you, Allexio ------------------------------------------------------------------------- Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT & business topics through brief surveys - and earn cash http://www.techsay.com/default.php?page=3Djoin.php&p=3Dsourceforge&CID=DEVD= EV _______________________________________________ Linux-hotplug-devel mailing list http://linux-hotplug.sourceforge.net Linux-hotplug-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-hotplug-devel