From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Kay Sievers" Date: Fri, 02 Jan 2009 11:25:26 +0000 Subject: Re: [PATCH] libudev: device - add devtype support Message-Id: List-Id: References: <1230866522.14544.4.camel@californication> In-Reply-To: <1230866522.14544.4.camel@californication> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: linux-hotplug@vger.kernel.org On Fri, Jan 2, 2009 at 09:22, Marcel Holtmann wrote: >> > I was playing a little bit with libudev and I actually need the DEVTYPE >> > from uevent for various tasks. Especially with USB and Bluetooth, the >> > subsystem value is too generic. >> > >> > Attached is a patch that implements udev_device_get_devtype() and also >> > udev_device_get_parent_with_devtype(). Please double check that I did it >> > the right way. >> >> Looks good. Applied. > > one minor thing that came to my mind is that DEVTYPE and subsystem are > actually kinda coupled. So a DEVTYPE="host" has a different semantic for > USB than for Bluetooth subsystem for example. Not sure if we actually > care or just add a udev_device_get_parent_with_subsystem_devtype() > function to give applications a choice if they wanna care. You mean replacing: udev_device_get_parent_with_devtype(..., *devtype) by: udev_device_get_parent_with_subsystem_devtype(..., *subsystem, *devtype) ? Sounds sensible, because in most cases you don't want to check for parents of a different subsystem. As you are using it, want to send a patch? Thanks, Kay