From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Kay Sievers" Date: Fri, 02 Jan 2009 16:27:21 +0000 Subject: Re: [PATCH] libudev: device - add devtype support Message-Id: List-Id: References: <1230866522.14544.4.camel@californication> In-Reply-To: <1230866522.14544.4.camel@californication> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable To: linux-hotplug@vger.kernel.org On Fri, Jan 2, 2009 at 17:17, David Zeuthen wrote: > On Fri, 2009-01-02 at 09:22 +0100, Marcel Holtmann wrote: >> > > I was playing a little bit with libudev and I actually need the DEVT= YPE >> > > from uevent for various tasks. Especially with USB and Bluetooth, the >> > > subsystem value is too generic. >> > > >> > > Attached is a patch that implements udev_device_get_devtype() and al= so >> > > udev_device_get_parent_with_devtype(). Please double check that I di= d it >> > > the right way. >> > >> > Looks good. Applied. >> >> one minor thing that came to my mind is that DEVTYPE and subsystem are >> actually kinda coupled. So a DEVTYPE=3D"host" has a different semantic f= or >> USB than for Bluetooth subsystem for example. Not sure if we actually >> care or just add a udev_device_get_parent_with_subsystem_devtype() >> function to give applications a choice if they wanna care. > > Isn't DEVTYPE in the environment already? Yeah, it's a property, just like SUBSYSTEM is. But It's a "core property", like a "subsystem subtype" which sounds fine to support in the API. > If so, just use the new API added here > > http://git.kernel.org/?p=3Dlinux/hotplug/udev.git;a=3Dcommit;h=F089350234= e39b868a5e3df71a8f8c036aaae4fd > > instead of Marcel's patch? In many cases you just walk along the parent devices, and lookup a specific device, without introducing dependencies on the specific devpath position, like the "two directories up"-crap many tools do. The enumeration API, which searches over all /sys devices does not really fit here. Kay