From mboxrd@z Thu Jan  1 00:00:00 1970
From: Kay Sievers <kay.sievers@vrfy.org>
Date: Thu, 11 Jun 2009 19:41:22 +0000
Subject: Re: [PATCH] Add bluetooth-hid2hci to udev-extras
Message-Id: <ac3eb2510906111241r423a01epfba052dbd3e67368@mail.gmail.com>
List-Id: <linux-hotplug.vger.kernel.org>
References: <4A303B6D.6020508@dell.com>
In-Reply-To: <4A303B6D.6020508@dell.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
To: linux-hotplug@vger.kernel.org

On Thu, Jun 11, 2009 at 18:13, Mario
Limonciello<mario_limonciello@dell.com> wrote:
> Thanks for the feedback. =C2=A0I've made the changes and am resubmitting.

This is all about adding USB devices, right? So the entire rules file
should be guarded by:
  ACTION=3D"add", ... out
  SUBSYSTEM=3D"usb", ... out
  ENV{DEVTYPE}=3D"usb_device", ... out

to exclude all other events from trying to match these rules. Also the
individual ACTION matches are not needed then.

+ ... ENV{ID_CLASS}=3D"mouse", ..., KERNEL=3D"mouse*", ...

I think the kernel name match is sufficient here, there is no need to
rely on earlier rules which set ID_CLASS.

+ ... ENV{ID_VENDOR}=3D"046d",

This is a property of usb_id, and usually a textual string and not a
number, I guess you better match against the sysfs attribute with
ATTR{}? The current stuff might work, but you should not rely on the
implicit fallback to numbers of usb_id.

+ RUN+=3D"/lib/udev/hid2hci ..."

Things in /lib/udev don't need the prefix, just use RUN+=3D"hid2hci ..."

Thanks,
Kay