From mboxrd@z Thu Jan  1 00:00:00 1970
From: Kay Sievers <kay.sievers@vrfy.org>
Date: Sun, 20 Sep 2009 04:00:16 +0000
Subject: Re: [BUG] udev doesn't run blkid on cdroms with one session
Message-Id: <ac3eb2510909192100g31e849eesf5eb8991be38f083@mail.gmail.com>
List-Id: <linux-hotplug.vger.kernel.org>
References: <1253411352.3791.14.camel@maxim-laptop>
In-Reply-To: <1253411352.3791.14.camel@maxim-laptop>
MIME-Version: 1.0
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
To: linux-hotplug@vger.kernel.org

On Sun, Sep 20, 2009 at 03:49, Maxim Levitsky <maximlevitsky@gmail.com> wro=
te:
> A line in 60-persistent-storage.rules states:
>
> KERNEL=3D"sr*", ENV{ID_CDROM_MEDIA}=3D"?*", IMPORT{program}=3D"/sbin/blki=
d -o udev -p -u noraid -O $env{ID_CDROM_MEDIA_SESSION_LAST_OFFSET} $tempnod=
e"
>
> It seems to assume that ID_CDROM_MEDIA_SESSION_LAST_OFFSET is always
> set, since otherwise blkid fails:
>
> maxim@maxim-laptop:~$ /sbin/blkid -o udev -p -u noraid -O =C2=A0/dev/sr0
> The low-probe option requires a device

In vol_id it was an optional parameter, and worked fine with an empty
option, at least when long options are used:
   { "offset", optional_argument, NULL, 'o' },

We could also make cdrom_id print the "0", that might be the simplest.

> maxim@maxim-laptop:~$ /sbin/blkid -o udev -p -u noraid =C2=A0 /dev/sr0
> ID_FS_LABEL=CDROM
> ID_FS_LABEL_ENC=CDROM\x20\x20\x20\x20\x20\x20\x20\x20\x20\x20\x20
> ID_FS_VERSION=3DJoliet\x20Extension
> ID_FS_TYPE=3Diso9660
> ID_FS_USAGE=3Dfilesystem
>
> Maybe this is a change in blkid
> (btw, you notice obvious bug, the label is 'padded' with spaces, I will
> report that to util-linux package maintainers)

Maybe this is expected in the *_ENC version of the string, I'm not sure.

Kay