From: "Robert P. J. Day" <rpjday@crashcourse.ca>
To: linux-hotplug@vger.kernel.org
Subject: can dependency on CONFIG_NET be dropped for
Date: Mon, 07 Jun 2010 11:53:19 +0000 [thread overview]
Message-ID: <alpine.DEB.2.00.1006070748180.25592@lynx> (raw)
based on a discussion on another mailing list, it would appear that
this dependency in kernel/sysctl.c is overkill:
#if defined(CONFIG_HOTPLUG) && defined(CONFIG_NET)
{
.procname = "hotplug",
.data = &uevent_helper,
.maxlen = UEVENT_HELPER_PATH_LEN,
.mode = 0644,
.proc_handler = proc_dostring,
},
#endif
as someone else explained, there is no need for that CONFIG_NET
dependency anymore, is there? as i read it, you'll already have
hotplug support -- all the above gives you is the
/proc/sys/kernel/hotplug file that allows you to override the default
setting of /sbin/hotplug, yes?
in the simple case, if it's feasible, one could just drop that
second dependency. or if you wanted to make the proc file a truly
separate config choice, just invent a new Kconfig variable like, say,
HOTPLUG_PROC_FILE which depends on HOTPLUG.
thoughts?
rday
p.s. the poster on the other list referred to these links:
http://article.gmane.org/gmane.linux.kernel/363682
http://article.gmane.org/gmane.linux.kernel/402057
by way of explanation.
--
====================================
Robert P. J. Day Waterloo, Ontario, CANADA
Linux Consulting, Training and Kernel Pedantry.
Web page: http://crashcourse.ca
Twitter: http://twitter.com/rpjday
====================================
next reply other threads:[~2010-06-07 11:53 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-07 11:53 Robert P. J. Day [this message]
2010-06-07 17:32 ` can dependency on CONFIG_NET be dropped for Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.00.1006070748180.25592@lynx \
--to=rpjday@crashcourse.ca \
--cc=linux-hotplug@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox