Linux Hotplug development
 help / color / mirror / Atom feed
From: Thomas Gleixner <tglx@linutronix.de>
To: Vincent Guittot <vincent.guittot@linaro.org>
Cc: linux-kernel@vger.kernel.org, linux-hotplug@vger.kernel.org,
	fweisbec@gmail.com, rostedt@goodmis.org,
	amit.kucheria@linaro.org, mingo@elte.hu, rusty@rustcorp.com.au
Subject: Re: [PATCH V6 2/2] tracing, perf: add cpu hotplug trace events
Date: Wed, 02 Mar 2011 09:38:44 +0000	[thread overview]
Message-ID: <alpine.LFD.2.00.1103021033260.2701@localhost6.localdomain6> (raw)
In-Reply-To: <AANLkTi=WRo41JprvcEH0Lgc_-j_bTX1MULgJFShV6W9g@mail.gmail.com>

On Tue, 1 Mar 2011, Vincent Guittot wrote:

> Trace the cpu state and the time spent in core and arch code

So you completely ignored my review comments, except for fixing up the
changelog.

	https://lkml.org/lkml/2011/2/24/297

All of the comments in the code still apply and either you fix it or
at least have the courtesy to explain why you think that those
comments do not need to be addressed.

Thanks,

	tglx

  reply	other threads:[~2011-03-02  9:38 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-03-01 16:06 [PATCH V6 2/2] tracing, perf: add cpu hotplug trace events Vincent Guittot
2011-03-02  9:38 ` Thomas Gleixner [this message]
2011-03-02  9:50   ` Vincent Guittot
2011-03-02  9:55     ` Thomas Gleixner
2011-03-02  9:58       ` Ingo Molnar
2011-03-02 16:27         ` Steven Rostedt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.LFD.2.00.1103021033260.2701@localhost6.localdomain6 \
    --to=tglx@linutronix.de \
    --cc=amit.kucheria@linaro.org \
    --cc=fweisbec@gmail.com \
    --cc=linux-hotplug@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=rostedt@goodmis.org \
    --cc=rusty@rustcorp.com.au \
    --cc=vincent.guittot@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox