* Re: wait_for_syfs errors
2004-10-22 20:12 wait_for_syfs errors Marcel Paulekuhn
@ 2004-10-22 20:17 ` Kay Sievers
2004-10-22 20:22 ` Marcel Paulekuhn
` (3 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: Kay Sievers @ 2004-10-22 20:17 UTC (permalink / raw)
To: linux-hotplug
On Fri, Oct 22, 2004 at 10:12:33PM +0200, Marcel Paulekuhn wrote:
> wait_for_sysfs[7840]: either wait_for_sysfs (udev 040) needs an update
> to handle the device '/class/i2c-adapter' properly (no device symlink)
> or the sysfs-support of your device's driver needs to be fixed, please
> report to <linux-hotplug-devel@lists.sourceforge.net>
>
> wait_for_sysfs[12789]: either wait_for_sysfs (udev 040) needs an
> update to handle the device '/class/sound' properly (class specific
> file unavailable) or the sysfs-support of your device's driver needs
> to be fixed, please report to
> <linux-hotplug-devel@lists.sourceforge.net>
You are running a -mm kernel, right? There is a bug in there, that
causes this.
Thanks,
Kay
-------------------------------------------------------
This SF.net email is sponsored by: IT Product Guide on ITManagersJournal
Use IT products in your business? Tell us what you think of them. Give us
Your Opinions, Get Free ThinkGeek Gift Certificates! Click to find out more
http://productguide.itmanagersjournal.com/guidepromo.tmpl
_______________________________________________
Linux-hotplug-devel mailing list http://linux-hotplug.sourceforge.net
Linux-hotplug-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-hotplug-devel
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: wait_for_syfs errors
2004-10-22 20:12 wait_for_syfs errors Marcel Paulekuhn
2004-10-22 20:17 ` Kay Sievers
@ 2004-10-22 20:22 ` Marcel Paulekuhn
2004-10-22 20:39 ` Kay Sievers
` (2 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: Marcel Paulekuhn @ 2004-10-22 20:22 UTC (permalink / raw)
To: linux-hotplug
Hm yeah, I am, 2.6.9-mm1.
So there's no other way to fix this than changing kernel? Because I
want to keep reiser4-support.
On Fri, 22 Oct 2004 22:17:46 +0200, Kay Sievers <kay.sievers@vrfy.org> wrote:
>
> You are running a -mm kernel, right? There is a bug in there, that
> causes this.
>
> Thanks,
> Kay
>
-------------------------------------------------------
This SF.net email is sponsored by: IT Product Guide on ITManagersJournal
Use IT products in your business? Tell us what you think of them. Give us
Your Opinions, Get Free ThinkGeek Gift Certificates! Click to find out more
http://productguide.itmanagersjournal.com/guidepromo.tmpl
_______________________________________________
Linux-hotplug-devel mailing list http://linux-hotplug.sourceforge.net
Linux-hotplug-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-hotplug-devel
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: wait_for_syfs errors
2004-10-22 20:12 wait_for_syfs errors Marcel Paulekuhn
2004-10-22 20:17 ` Kay Sievers
2004-10-22 20:22 ` Marcel Paulekuhn
@ 2004-10-22 20:39 ` Kay Sievers
2004-10-22 23:23 ` Greg KH
2004-10-23 1:59 ` Kay Sievers
4 siblings, 0 replies; 6+ messages in thread
From: Kay Sievers @ 2004-10-22 20:39 UTC (permalink / raw)
To: linux-hotplug
On Fri, Oct 22, 2004 at 10:22:29PM +0200, Marcel Paulekuhn wrote:
> Hm yeah, I am, 2.6.9-mm1.
>
> So there's no other way to fix this than changing kernel? Because I
> want to keep reiser4-support.
>
>
> On Fri, 22 Oct 2004 22:17:46 +0200, Kay Sievers <kay.sievers@vrfy.org> wrote:
> >
> > You are running a -mm kernel, right? There is a bug in there, that
> > causes this.
The message is not critical. It just means, that you get (useless) hotplug
events for the class itself which should not happen. This will hopefully
fixed soon in the -mm tree and will go away.
Kay
-------------------------------------------------------
This SF.net email is sponsored by: IT Product Guide on ITManagersJournal
Use IT products in your business? Tell us what you think of them. Give us
Your Opinions, Get Free ThinkGeek Gift Certificates! Click to find out more
http://productguide.itmanagersjournal.com/guidepromo.tmpl
_______________________________________________
Linux-hotplug-devel mailing list http://linux-hotplug.sourceforge.net
Linux-hotplug-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-hotplug-devel
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: wait_for_syfs errors
2004-10-22 20:12 wait_for_syfs errors Marcel Paulekuhn
` (2 preceding siblings ...)
2004-10-22 20:39 ` Kay Sievers
@ 2004-10-22 23:23 ` Greg KH
2004-10-23 1:59 ` Kay Sievers
4 siblings, 0 replies; 6+ messages in thread
From: Greg KH @ 2004-10-22 23:23 UTC (permalink / raw)
To: linux-hotplug
On Fri, Oct 22, 2004 at 10:39:07PM +0200, Kay Sievers wrote:
> On Fri, Oct 22, 2004 at 10:22:29PM +0200, Marcel Paulekuhn wrote:
> > Hm yeah, I am, 2.6.9-mm1.
> >
> > So there's no other way to fix this than changing kernel? Because I
> > want to keep reiser4-support.
> >
> >
> > On Fri, 22 Oct 2004 22:17:46 +0200, Kay Sievers <kay.sievers@vrfy.org> wrote:
> > >
> > > You are running a -mm kernel, right? There is a bug in there, that
> > > causes this.
>
> The message is not critical. It just means, that you get (useless) hotplug
> events for the class itself which should not happen. This will hopefully
> fixed soon in the -mm tree and will go away.
Actually I just commited that change to the main kernel tree, so we need
to fix this up in wait_for_sysfs before we start to get a lot of people
complaining :)
thanks,
greg k-h
-------------------------------------------------------
This SF.net email is sponsored by: IT Product Guide on ITManagersJournal
Use IT products in your business? Tell us what you think of them. Give us
Your Opinions, Get Free ThinkGeek Gift Certificates! Click to find out more
http://productguide.itmanagersjournal.com/guidepromo.tmpl
_______________________________________________
Linux-hotplug-devel mailing list http://linux-hotplug.sourceforge.net
Linux-hotplug-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-hotplug-devel
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: wait_for_syfs errors
2004-10-22 20:12 wait_for_syfs errors Marcel Paulekuhn
` (3 preceding siblings ...)
2004-10-22 23:23 ` Greg KH
@ 2004-10-23 1:59 ` Kay Sievers
4 siblings, 0 replies; 6+ messages in thread
From: Kay Sievers @ 2004-10-23 1:59 UTC (permalink / raw)
To: linux-hotplug
[-- Attachment #1: Type: text/plain, Size: 1012 bytes --]
On Fri, Oct 22, 2004 at 04:23:52PM -0700, Greg KH wrote:
> On Fri, Oct 22, 2004 at 10:39:07PM +0200, Kay Sievers wrote:
> > On Fri, Oct 22, 2004 at 10:22:29PM +0200, Marcel Paulekuhn wrote:
> > > Hm yeah, I am, 2.6.9-mm1.
> > >
> > > So there's no other way to fix this than changing kernel? Because I
> > > want to keep reiser4-support.
> > >
> > >
> > > On Fri, 22 Oct 2004 22:17:46 +0200, Kay Sievers <kay.sievers@vrfy.org> wrote:
> > > >
> > > > You are running a -mm kernel, right? There is a bug in there, that
> > > > causes this.
> >
> > The message is not critical. It just means, that you get (useless) hotplug
> > events for the class itself which should not happen. This will hopefully
> > fixed soon in the -mm tree and will go away.
>
> Actually I just commited that change to the main kernel tree, so we need
> to fix this up in wait_for_sysfs before we start to get a lot of people
> complaining :)
Ok, here is the fix. Bad events with no device in the class are now ignored.
Thanks,
Kay
[-- Attachment #2: wait-bad_event-01.patch --]
[-- Type: text/plain, Size: 626 bytes --]
===== wait_for_sysfs.c 1.27 vs edited =====
--- 1.27/wait_for_sysfs.c 2004-10-19 03:50:52 +02:00
+++ edited/wait_for_sysfs.c 2004-10-23 03:57:33 +02:00
@@ -99,6 +99,12 @@
snprintf(filename, SYSFS_PATH_MAX-1, "%s%s", sysfs_mnt_path, devpath);
filename[SYSFS_PATH_MAX-1] = '\0';
+ /* skip bad events where we get no device for the class */
+ if (strncmp(devpath, "/class/", 7) == 0 && strchr(&devpath[7], '/') == NULL) {
+ dbg("no device name for '%s', bad event", devpath);
+ goto exit;
+ }
+
/* open the class device we are called for */
class_dev = open_class_device_wait(filename);
if (!class_dev) {
^ permalink raw reply [flat|nested] 6+ messages in thread