Re: cm4000 device creation again

[Jan Niehusmann <jan@gondor.com>]

[-- Attachment #1: Type: text/plain, Size: 756 bytes --]

Sorry for replying to my own posting ;-)

Jan Niehusmann wrote:
> So it looks to me like either class_device_create doesn't get called if
> the cm4000_cs gets loaded in response to the card being inserted, or it
> does get called but doesn't work because something else is not yet
> properly initialized at that time.

Looks like it's the second: Calling major=register_chrdev(...) before
calling pcmcia_register_driver(...) in cmm_init() does help.

So the problem was that cm4000_probe got called in response to
pcmcia_register_driver, even before register_chrdev got called.
Therefore, class_device_create didn't get a proper major number and failed.

Patch attached, but as I'm writing this through gmane, I'm not sure if
the patch will survive.

Jan


[-- Attachment #2: cm4000-udev.diff --]
[-- Type: text/plain, Size: 635 bytes --]

diff --git a/drivers/char/pcmcia/cm4000_cs.c b/drivers/char/pcmcia/cm4000_cs.c
index 02114a0..0550038 100644
--- a/drivers/char/pcmcia/cm4000_cs.c
+++ b/drivers/char/pcmcia/cm4000_cs.c
@@ -1981,10 +1981,6 @@ static int __init cmm_init(void)
 	if (!cmm_class)
 		return -1;
 
-	rc = pcmcia_register_driver(&cm4000_driver);
-	if (rc < 0)
-		return rc;
-
 	major = register_chrdev(0, DEVICE_NAME, &cm4000_fops);
 	if (major < 0) {
 		printk(KERN_WARNING MODULE_NAME
@@ -1992,6 +1988,11 @@ static int __init cmm_init(void)
 		return -1;
 	}
 
+	rc = pcmcia_register_driver(&cm4000_driver);
+	if (rc < 0)
+		return rc;
+
+
 	return 0;
 }