From: "Yury G. Kudryashov" <urkud@ya.ru>
To: linux-hotplug@vger.kernel.org
Subject: Re: two patches
Date: Fri, 16 Apr 2010 17:51:16 +0000 [thread overview]
Message-ID: <hqa82l$k31$1@dough.gmane.org> (raw)
In-Reply-To: <hq8tri$lcc$1@dough.gmane.org>
Dan Nicholson wrote:
>> @@ -156,7 +156,7 @@ EXTRA_DIST += \
>> udev/udevd.xml
>>
>> %.7 %.8 : %.xml
>> - $(XSLTPROC) -o $@ -nonet
>> http://docbook.sourceforge.net/release/xsl/current/manpages/docbook.xsl
>> $<
>> + $(XSLTPROC) -o $@
>> http://docbook.sourceforge.net/release/xsl/current/manpages/docbook.xsl
>> $<
>
> This is an unrelated change. Please remove it from this patch.
Oops. Sorry. I should've reread the patch before sending.
>> + [
>> + OLD_IFS=$IFS
>> + IFS=:
>> + for i in $with_firmware_path
>> + do
>> + if [ "x${FIRMWARE_PATH}" = "x" ]; then
>> + FIRMWARE_PATH="\\\"${i}/\\\""
>> + else
>> + FIRMWARE_PATH="${FIRMWARE_PATH}, \\\"${i}/\\\""
>> + fi
>> + done
>> + IFS=$OLD_IFS
>> + ]
>
> I'm not sure what wrapping this whole section in [] quoting does. It looks
> like a good handling of the option, though.
It escapes "if [ ... ]".
next prev parent reply other threads:[~2010-04-16 17:51 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-16 5:50 two patches Yury G. Kudryashov
2010-04-16 15:28 ` Dan Nicholson
2010-04-16 16:31 ` Kay Sievers
2010-04-16 17:34 ` Dan Nicholson
2010-04-16 17:51 ` Yury G. Kudryashov [this message]
2010-04-16 18:03 ` Dan Nicholson
2010-04-16 18:52 ` Yury G. Kudryashov
2010-04-16 18:56 ` Yury G. Kudryashov
2010-04-16 19:01 ` Yury G. Kudryashov
2010-04-16 22:01 ` Dan Nicholson
2010-04-16 22:02 ` Dan Nicholson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='hqa82l$k31$1@dough.gmane.org' \
--to=urkud@ya.ru \
--cc=linux-hotplug@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).