From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Yury G. Kudryashov" <urkud@ya.ru>
Date: Fri, 16 Apr 2010 17:51:16 +0000
Subject: Re: two patches
Message-Id: <hqa82l$k31$1@dough.gmane.org>
List-Id: <linux-hotplug.vger.kernel.org>
References: <hq8tri$lcc$1@dough.gmane.org>
In-Reply-To: <hq8tri$lcc$1@dough.gmane.org>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: linux-hotplug@vger.kernel.org

Dan Nicholson wrote:

>> @@ -156,7 +156,7 @@ EXTRA_DIST += \
>>  udev/udevd.xml
>>  
>>  %.7 %.8 : %.xml
>> -	$(XSLTPROC) -o $@ -nonet
>> http://docbook.sourceforge.net/release/xsl/current/manpages/docbook.xsl
>> $<
>> +	$(XSLTPROC) -o $@
>> http://docbook.sourceforge.net/release/xsl/current/manpages/docbook.xsl
>> $<
> 
> This is an unrelated change. Please remove it from this patch.
Oops. Sorry. I should've reread the patch before sending.
>> +	[
>> +	OLD_IFS=$IFS
>> +	IFS=:
>> +	for i in $with_firmware_path
>> +	do
>> +		if [ "x${FIRMWARE_PATH}" = "x" ]; then
>> +			FIRMWARE_PATH="\\\"${i}/\\\""
>> +		else
>> +			FIRMWARE_PATH="${FIRMWARE_PATH}, \\\"${i}/\\\""
>> +		fi
>> +	done
>> +	IFS=$OLD_IFS
>> +	]
> 
> I'm not sure what wrapping this whole section in [] quoting does. It looks
> like a good handling of the option, though.
It escapes "if [ ... ]".