Re: [PATCH] The Mandriva Collection

[Olivier Blin <oblin@mandriva.com>]

md@Linux.IT (Marco d'Itri) writes:

> On Dec 12, Olivier Blin <oblin@mandriva.com> wrote:
>
>> But is there any way currently to request fxload on hotplug event, or
>> should it be triggered when the device is plugged?
>> The later would require an udev rule per device IDs, which is the
>> equivalent of usermaps.
> Yes, but again there is nothing wrong with this. The first VID/PID
> pair will make udev run fxload, then the second one will appear and the
> kernel driver will be loaded.

It requires to compare twice more all IDs for each plugged USB device,
which is avoided when using request_firmware().

And it needs a VID/PID rules list, which may not be easy to write
without duplication. What's the proper construction to replace this
kind of usermaps?

ACTION="add", SUBSYSTEM="usb", \
 SYSFS{idProduct}="xxxA", SYSFS{idVendor}="yyyA", \
 RUN+="/sbin/fxload -t fx2 -I /lib/firmware/ezusb/foo.hex"
ACTION="add", SUBSYSTEM="usb", \
 SYSFS{idProduct}="xxxB", SYSFS{idVendor}="yyyB", \
 RUN+="/sbin/fxload -t fx2 -I /lib/firmware/ezusb/foo.hex"
ACTION="add", SUBSYSTEM="usb", \
 SYSFS{idProduct}="xxxC", SYSFS{idVendor}="yyyC", \
 RUN+="/sbin/fxload -t fx2 -I /lib/firmware/ezusb/bar.hex"
ACTION="add", SUBSYSTEM="usb", \
 SYSFS{idProduct}="xxxD", SYSFS{idVendor}="yyyD", \
 RUN+="/sbin/fxload -t fx2 -I /lib/firmware/ezusb/bar.hex"

Writing dozens of such rules is very verbose, not readable at all, and
error prone. Is there at least some tool to automate this?

It can probably be simplified using PRODUCT values:

ACTION="add", SUBSYSTEM="usb", \
 ENV{PRODUCT}="xxxA/yyyA/*|xxxB/yyyB/*", \
 RUN+="/sbin/fxload -t fx2 -I /lib/firmware/ezusb/foo.hex"
ACTION="add", SUBSYSTEM="usb", \
 ENV{PRODUCT}="xxxC/yyyC/*|xxxD/yyyD/*" \
 RUN+="/sbin/fxload -t fx2 -I /lib/firmware/ezusb/bar.hex"

More generally, is there some construction to factorize this?
condA, condB, cond1, cond2, RUN+="fxload foo"
condA, condB, cond3, cond4, RUN+="fxload foo"
condA, condB, cond5, cond6, RUN+="fxload bar"
condA, condB, cond7, cond8, RUN+="fxload bar"

It duplicates condA and condB tests for all rules, and copy-paste
errors may be hard to spot because of long rules. (this example looks
short, but it gets trickier when condX and RUN values are expanded to
longer expressions).
Can we use environment variables to solve this, or is there something
better?

!condA, GOTO "fxload_end"
!condB, GOTO "fxload_end"
cond1, cond2, ENV{FXLOAD_FILE}=foo, GOTO="fxload_do"
cond3, cond4, ENV{FXLOAD_FILE}=foo, GOTO="fxload_do"
cond5, cond6, ENV{FXLOAD_FILE}ºr, GOTO="fxload_do"
cond7, cond8, ENV{FXLOAD_FILE}ºr, GOTO="fxload_do"
ENV{FXLOAD_FILE}!="?*", GOTO="fxload_end"
LABEL="fxload_do", RUN+="fxload $FXLOAD_FILE"
LABEL="fxload_end"

-- 
Olivier Blin - Mandriva



-------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc. Do you grep through log files
for problems?  Stop!  Download the new AJAX search engine that makes
searching your log files as easy as surfing the  web.  DOWNLOAD SPLUNK!
http://ads.osdn.com/?ad_idv37&alloc_id\x16865&op=click
_______________________________________________
Linux-hotplug-devel mailing list  http://linux-hotplug.sourceforge.net
Linux-hotplug-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-hotplug-devel