aic7xxx and hotplug : part II

aic7xxx and hotplug : part II

[christophe barbe]

So I've proposed the patch to the driver author. The export table macro was
already in the pending patch for 2.4.12. So this should be solved soon.

Remains a problem, I get a OOPS when I do the following :
. insert card (card detected, module loaded)
. mount /dev/sdc0 /cdrw
. use /cdrw
. umount /cdrw
. remove the card
. mount /dev/sdc0 /cdrw (oops and mount segfault)

lspci show the adaptec card when inserted
...
00:13.0 CardBus bridge: Toshiba America Info Systems ToPIC95 (rev 07)
00:13.1 CardBus bridge: Toshiba America Info Systems ToPIC95 (rev 07)
14:00.0 SCSI storage controller: Adaptec AIC-1480 / APA-1480 (rev 03)
and no more after reemoving the card.

I see in /var/log/message that the 'PCI remove event' is not supported by
hotplug  
Oct 16 17:33:13 turing kernel: cs: cb_free(bus 20)
Oct 16 17:33:14 turing /etc/hotplug/pci.agent: PCI remove event not
supported

My understanding was that here the hotplug job was only to unload the
driver but because it can be used by another device, I understand it's not
so simple.

But the oops tells me that Something is required. It looks like the driver
still believe that the card is available. 
Is it something that must be done like ask to the driver to rescan its own
devices.

Christophe



-- 
Christophe Barbé <christophe.barbe@online.fr>
GnuPG FingerPrint: E0F6 FADF 2A5C F072 6AF8  F67A 8F45 2F1E D72C B41E

_______________________________________________
Linux-hotplug-devel mailing list  http://linux-hotplug.sourceforge.net
Linux-hotplug-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-hotplug-devel

Re: aic7xxx and hotplug : part II

[Greg KH]

On Tue, Oct 16, 2001 at 06:13:26PM +0200, christophe barbe wrote:
> . mount /dev/sdc0 /cdrw (oops and mount segfault)

Please run the oops through ksymoops and send it to the driver's author.
We can't do much here :)

thanks,

greg k-h

_______________________________________________
Linux-hotplug-devel mailing list  http://linux-hotplug.sourceforge.net
Linux-hotplug-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-hotplug-devel

Re: aic7xxx and hotplug : part II

[christophe barbe]

Le 2001.10.16 18:41:58 +0200, Greg KH a écrit :
> On Tue, Oct 16, 2001 at 06:13:26PM +0200, christophe barbe wrote:
> > . mount /dev/sdc0 /cdrw (oops and mount segfault)
> 
> Please run the oops through ksymoops and send it to the driver's author.
> We can't do much here :)

So do you suggest me that this is a problem with the driver.
I was convinced it was because nobody notified the driver that the device
was removed.

I need to do some other test but I guess that if I manually unload the
driver then I will avoid the oops.

Christophe

> thanks,
> 
> greg k-h
> 
> _______________________________________________
> Linux-hotplug-devel mailing list  http://linux-hotplug.sourceforge.net
> Linux-hotplug-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/linux-hotplug-devel
> 
-- 
Christophe Barbé <christophe.barbe@online.fr>
GnuPG FingerPrint: E0F6 FADF 2A5C F072 6AF8  F67A 8F45 2F1E D72C B41E

_______________________________________________
Linux-hotplug-devel mailing list  http://linux-hotplug.sourceforge.net
Linux-hotplug-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-hotplug-devel

Re: aic7xxx and hotplug : part II

[Greg KH]

On Tue, Oct 16, 2001 at 07:42:34PM +0200, christophe barbe wrote:
> 
> So do you suggest me that this is a problem with the driver.

Yes.

> I was convinced it was because nobody notified the driver that the device
> was removed.

The driver knows that it was removed due to the pci interface.  The
linux-hotplug package is for notifying userspace that a device was
removed, not for telling the driver this :)

thanks,

greg k-h

_______________________________________________
Linux-hotplug-devel mailing list  http://linux-hotplug.sourceforge.net
Linux-hotplug-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-hotplug-devel

Re: aic7xxx and hotplug : part II

[David Brownell]

> > Please run the oops through ksymoops and send it to the driver's author.
> > We can't do much here :)
> 
> So do you suggest me that this is a problem with the driver.

Nobody can do more than "suggest" without facts like
the ksymoops output ...


> I was convinced it was because nobody notified the driver that the device
> was removed.

The kernel tells the driver when the device goes away.
Of course that might be _after_ the CardBus device was
physically removed; the driver has to cope with that.

- Dave




_______________________________________________
Linux-hotplug-devel mailing list  http://linux-hotplug.sourceforge.net
Linux-hotplug-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-hotplug-devel

Re: aic7xxx and hotplug : part II

[christophe barbe]

[-- Attachment #1: Type: text/plain, Size: 946 bytes --]

Ok sorry if it takes time for me to understand.
You start convinced me that the problem can be from the driver.

I attach the oops and the ksymoops output.

Christophe


Le 2001.10.16 20:15:27 +0200, David Brownell a écrit :
> > > Please run the oops through ksymoops and send it to the driver's
> author.
> > > We can't do much here :)
> > 
> > So do you suggest me that this is a problem with the driver.
> 
> Nobody can do more than "suggest" without facts like
> the ksymoops output ...
> 
> 
> > I was convinced it was because nobody notified the driver that the
> device
> > was removed.
> 
> The kernel tells the driver when the device goes away.
> Of course that might be _after_ the CardBus device was
> physically removed; the driver has to cope with that.
> 
> - Dave
> 
> 
> 
> 
-- 
Christophe Barbé <christophe.barbe@online.fr>
GnuPG FingerPrint: E0F6 FADF 2A5C F072 6AF8  F67A 8F45 2F1E D72C B41E

[-- Attachment #2: ksymoops.mount --]
[-- Type: application/octet-stream, Size: 3846 bytes --]

ksymoops 2.4.3 on i586 2.4.12.  Options used
     -V (default)
     -k /proc/ksyms (default)
     -l /proc/modules (default)
     -o /lib/modules/2.4.12/ (default)
     -M (specified)

Reading Oops report from the terminal
Oct 16 17:33:35 turing kernel:  printing eip:
Oct 16 17:33:35 turing kernel: c019d01a
Oct 16 17:33:35 turing kernel: Oops: 0000
Oct 16 17:33:35 turing kernel: CPU:    0
Oct 16 17:33:35 turing kernel: EIP:    0010:[scsi_dispatch_cmd+158/368]    Not tainted
Oct 16 17:33:35 turing kernel: EFLAGS: 00210246
Oct 16 17:33:35 turing kernel: eax: 00000000   ebx: c2773e00   ecx: c2773e80   edx: 087c4678
Oct 16 17:33:35 turing kernel: esi: c5fe3ed4   edi: c56980e0   ebp: c2773e00   esp: c163bc18
Oct 16 17:33:35 turing kernel: ds: 0018   es: 0018   ss: 0018
Oct 16 17:33:35 turing kernel: Process mount (pid: 793, stackpage=c163b000)
Oct 16 17:33:35 turing kernel: Stack: c2773e00 c5fe3ed4 c2773eac c5fe3ed4 00000000 c01a2d6f c2773e00 c2773e00 
Oct 16 17:33:35 turing kernel:        00200286 c4e56818 c163bcd0 c5fe3e80 00000000 c56980e0 c4e56800 c5fe3e80 
Oct 16 17:33:35 turing kernel:        c01a2356 c4e56818 c5fe3e80 c163bd40 c01a239d c4e56818 c5fe3ed4 c5fe3e80 
Oct 16 17:33:35 turing kernel: Call Trace: [scsi_request_fn+687/740] [__scsi_insert_special+102/112] [scsi_insert_special_req+25/32] [scsi_do_req+172/180] [scsi_wait_req+116/168] 
Oct 16 17:33:35 turing kernel:    [scsi_wait_done+0/32] [sr_do_ioctl+251/712] [test_unit_ready+91/100] [sr_drive_status+34/60] [open_for_data+54/708] [cdrom_open+142/200] 
Oct 16 17:33:35 turing kernel:    [do_open+124/292] [blkdev_get+104/120] [get_sb_bdev+230/716] [set_devname+39/84] [do_kern_mount+175/316] [do_add_mount+29/204] 
Oct 16 17:33:35 turing kernel:    [do_mount+286/312] [copy_mount_options+76/156] [sys_mount+124/188] [system_call+51/64] 
Oct 16 17:33:35 turing kernel: 
Oct 16 17:33:35 turing kernel: Code: f6 40 67 04 74 07 68 d8 01 1a c0 eb 05 68 50 15 1a c0 ff 75 
Oct 16 17:33:35 turing kernel: c019d01a
Oct 16 17:33:35 turing kernel: Oops: 0000
Oct 16 17:33:35 turing kernel: CPU:    0
Oct 16 17:33:35 turing kernel: EIP:    0010:[scsi_dispatch_cmd+158/368]    Not tainted
Oct 16 17:33:35 turing kernel: EFLAGS: 00210246
Oct 16 17:33:35 turing kernel: eax: 00000000   ebx: c2773e00   ecx: c2773e80   edx: 087c4678
Oct 16 17:33:35 turing kernel: esi: c5fe3ed4   edi: c56980e0   ebp: c2773e00   esp: c163bc18
Oct 16 17:33:35 turing kernel: ds: 0018   es: 0018   ss: 0018
Oct 16 17:33:35 turing kernel: Process mount (pid: 793, stackpage=c163b000)
Oct 16 17:33:35 turing kernel: Stack: c2773e00 c5fe3ed4 c2773eac c5fe3ed4 00000000 c01a2d6f c2773e00 c2773e00 
Oct 16 17:33:35 turing kernel:        00200286 c4e56818 c163bcd0 c5fe3e80 00000000 c56980e0 c4e56800 c5fe3e80 
Oct 16 17:33:35 turing kernel:        c01a2356 c4e56818 c5fe3e80 c163bd40 c01a239d c4e56818 c5fe3ed4 c5fe3e80 
Oct 16 17:33:35 turing kernel: Call Trace: [scsi_request_fn+687/740] [__scsi_insert_special+102/112] [scsi_insert_special_req+25/32] [scsi_do_req+172/180] [scsi_wait_req+116/168] 
Oct 16 17:33:35 turing kernel: Code: f6 40 67 04 74 07 68 d8 01 1a c0 eb 05 68 50 15 1a c0 ff 75 
Using defaults from ksymoops -t elf32-i386 -a i386

Code;  00000000 Before first symbol
00000000 <_EIP>:
Code;  00000000 Before first symbol
   0:   f6 40 67 04               testb  $0x4,0x67(%eax)
Code;  00000004 Before first symbol
   4:   74 07                     je     d <_EIP+0xd> 0000000c Before first symbol
Code;  00000006 Before first symbol
   6:   68 d8 01 1a c0            push   $0xc01a01d8
Code;  0000000a Before first symbol
   b:   eb 05                     jmp    12 <_EIP+0x12> 00000012 Before first symbol
Code;  0000000c Before first symbol
   d:   68 50 15 1a c0            push   $0xc01a1550
Code;  00000012 Before first symbol
  12:   ff 75 00                  pushl  0x0(%ebp)

[-- Attachment #3: oops.mount --]
[-- Type: application/octet-stream, Size: 1727 bytes --]

Oct 16 17:33:35 turing kernel:  printing eip:
Oct 16 17:33:35 turing kernel: c019d01a
Oct 16 17:33:35 turing kernel: Oops: 0000
Oct 16 17:33:35 turing kernel: CPU:    0
Oct 16 17:33:35 turing kernel: EIP:    0010:[scsi_dispatch_cmd+158/368]    Not tainted
Oct 16 17:33:35 turing kernel: EFLAGS: 00210246
Oct 16 17:33:35 turing kernel: eax: 00000000   ebx: c2773e00   ecx: c2773e80   edx: 087c4678
Oct 16 17:33:35 turing kernel: esi: c5fe3ed4   edi: c56980e0   ebp: c2773e00   esp: c163bc18
Oct 16 17:33:35 turing kernel: ds: 0018   es: 0018   ss: 0018
Oct 16 17:33:35 turing kernel: Process mount (pid: 793, stackpage=c163b000)
Oct 16 17:33:35 turing kernel: Stack: c2773e00 c5fe3ed4 c2773eac c5fe3ed4 00000000 c01a2d6f c2773e00 c2773e00 
Oct 16 17:33:35 turing kernel:        00200286 c4e56818 c163bcd0 c5fe3e80 00000000 c56980e0 c4e56800 c5fe3e80 
Oct 16 17:33:35 turing kernel:        c01a2356 c4e56818 c5fe3e80 c163bd40 c01a239d c4e56818 c5fe3ed4 c5fe3e80 
Oct 16 17:33:35 turing kernel: Call Trace: [scsi_request_fn+687/740] [__scsi_insert_special+102/112] [scsi_insert_special_req+25/32] [scsi_do_req+172/180] [scsi_wait_req+116/168] 
Oct 16 17:33:35 turing kernel:    [scsi_wait_done+0/32] [sr_do_ioctl+251/712] [test_unit_ready+91/100] [sr_drive_status+34/60] [open_for_data+54/708] [cdrom_open+142/200] 
Oct 16 17:33:35 turing kernel:    [do_open+124/292] [blkdev_get+104/120] [get_sb_bdev+230/716] [set_devname+39/84] [do_kern_mount+175/316] [do_add_mount+29/204] 
Oct 16 17:33:35 turing kernel:    [do_mount+286/312] [copy_mount_options+76/156] [sys_mount+124/188] [system_call+51/64] 
Oct 16 17:33:35 turing kernel: 
Oct 16 17:33:35 turing kernel: Code: f6 40 67 04 74 07 68 d8 01 1a c0 eb 05 68 50 15 1a c0 ff 75 

Re: aic7xxx and hotplug : part II

[Greg KH]

On Tue, Oct 16, 2001 at 10:22:49PM +0200, christophe barbe wrote:
> Ok sorry if it takes time for me to understand.
> You start convinced me that the problem can be from the driver.
> 
> I attach the oops and the ksymoops output.

You might want to send this to the author of the driver, along with the
steps that you did to get the oops.

thanks,

greg k-h

_______________________________________________
Linux-hotplug-devel mailing list  http://linux-hotplug.sourceforge.net
Linux-hotplug-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-hotplug-devel

Re: aic7xxx and hotplug : part II

[christophe barbe]

I'm doing it now that I'm convinced that it's a driver bug.
Thank for your help.

Christophe

Le 2001.10.16 22:27:23 +0200, Greg KH a écrit :
> On Tue, Oct 16, 2001 at 10:22:49PM +0200, christophe barbe wrote:
> > Ok sorry if it takes time for me to understand.
> > You start convinced me that the problem can be from the driver.
> > 
> > I attach the oops and the ksymoops output.
> 
> You might want to send this to the author of the driver, along with the
> steps that you did to get the oops.
> 
> thanks,
> 
> greg k-h
> 
-- 
Christophe Barbé <christophe.barbe@online.fr>
GnuPG FingerPrint: E0F6 FADF 2A5C F072 6AF8  F67A 8F45 2F1E D72C B41E

_______________________________________________
Linux-hotplug-devel mailing list  http://linux-hotplug.sourceforge.net
Linux-hotplug-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-hotplug-devel