From: David Brownell <david-b@pacbell.net>
To: linux-hotplug@vger.kernel.org
Subject: Re: Unloading drivers, start-up, shut-down and some clean-ups
Date: Thu, 27 Dec 2001 17:20:30 +0000 [thread overview]
Message-ID: <marc-linux-hotplug-100947382218653@msgid-missing> (raw)
In-Reply-To: <marc-linux-hotplug-100190866102262@msgid-missing>
The first time you sent things around, they weren't in
the form of digestible/reviewable patches ... just an
entire rewrite. I asked for a more reviewable form,
but the second iteration looked like the same, and
so does this one.
What that does is magnify the time/cost needed to
look at things, and increase the risk of breaking
things when some unexpected interaction doesn't
get noticed in the review, and didn't get fixed.
Rather than complain that I'm not investing that extra
time, perhaps you would consider spending it yourself
to provide a series of MUCH smaller patches, where
each one is reasonably sized and independently
reviewable???
I don't think that's too much to ask. There's some
good stuff in there, but it's hard to get at it past the
"gratuitous rewrite" type of changes.
- Dave
> I wrote:
>
> > If nothing else, then somebody at least do the *.agent *.rc script
> > unification! (please?)
>
>
> Um, actually, that 'somebody' is probably David Brownell who might
> kindly include some of my contributions in CVS, perhaps?
>
> I have the impression that we are wasting valuable time.
_______________________________________________
Linux-hotplug-devel mailing list http://linux-hotplug.sourceforge.net
Linux-hotplug-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-hotplug-devel
prev parent reply other threads:[~2001-12-27 17:20 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-10-01 1:13 Unloading drivers, start-up, shut-down and some clean-ups Stamatis Mitrofanis
2001-10-05 8:09 ` David Brownell
2001-10-06 4:13 ` Stamatis Mitrofanis
2001-12-18 14:25 ` Harald Barth
2001-12-20 21:28 ` Stamatis Mitrofanis
2001-12-26 22:49 ` Stamatis Mitrofanis
2001-12-27 17:20 ` David Brownell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=marc-linux-hotplug-100947382218653@msgid-missing \
--to=david-b@pacbell.net \
--cc=linux-hotplug@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).