From mboxrd@z Thu Jan 1 00:00:00 1970 From: Fumitoshi UKAI Date: Tue, 08 Jan 2002 17:47:32 +0000 Subject: Re: REMOVER support without usbdevfs Message-Id: List-Id: References: In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: linux-hotplug@vger.kernel.org At Mon, 07 Jan 2002 10:18:22 -0800, David Brownell wrote: > > Looks right to me. Please submit a patch to fix this bug. I just committed a following patch to cvs repository. Is this ok? Index: usb.agent =================================RCS file: /cvsroot/linux-hotplug/admin/etc/hotplug/usb.agent,v retrieving revision 1.15 diff -u -u -r1.15 usb.agent --- usb.agent 2001/09/07 15:57:39 1.15 +++ usb.agent 2002/01/08 17:43:42 @@ -281,7 +281,11 @@ # declare a REMOVER name that the add action can use to create a # remover, or that the remove action can use to execute a remover. # -declare -rx REMOVER=/var/run/usb/`echo $DEVICE | sed -e 's;/;%;g'` +if [ "$DEVICE" = "" ]; then + declare -rx REMOVER=/var/run/usb/`echo "$INTERFACE/$PRODUCT/$TYPE" | sed -e 's;/;%;g'` +else + declare -rx REMOVER=/var/run/usb/`echo $DEVICE | sed -e 's;/;%;g'` +fi # # What to do with this USB hotplug event? Regards, Fumitoshi UKAI > ----- Original Message ----- > From: "Fumitoshi UKAI" > To: > Sent: Monday, January 07, 2002 9:28 AM > Subject: REMOVER support without usbdevfs > > > > Hi, > > > > I've receive the following bug reports: http://bugs.debian.org/128121 > > > > > In /etc/hotplug/usb.agent REMOVER is made from the contens of DEVICE > > > which is empty if usbdevfs is not present, i.e. REMOVER will be set > > > to /var/run/usb/ instead of /var/run/usb/somefile. > > > > > Thus program relying on REMOVER to install a remover script will > > > fail to do so. > > > > > I've circumvented this by checking whether DEVICE is empty and then > > > generating REMOVER from INTERFACE PRODUCT and TYPE. note however > > > that DEVICE may not be set to anything, since hotplug.functions > > > takes it as an indicator whether usbdevfs is present or not. > > > > So is there any problem like this? > > > > if [ "$DEVICE" = "" ]; then > > declare -rx REMOVER=/var/run/usb/`echo "$INTERFACE/$PRODUCT/$TYPE" | sed -e 's;/;%;g'` > > else > > declare -rx REMOVER=/var/run/usb/`echo $DEVICE | sed -e 's;/;%;g'` > > fi > > > > Regards, > > Fumitoshi UKAI > > > > _______________________________________________ > > Linux-hotplug-devel mailing list http://linux-hotplug.sourceforge.net > > Linux-hotplug-devel@lists.sourceforge.net > > https://lists.sourceforge.net/lists/listinfo/linux-hotplug-devel > > _______________________________________________ Linux-hotplug-devel mailing list http://linux-hotplug.sourceforge.net Linux-hotplug-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-hotplug-devel