From: Olaf Hering <olh@suse.de>
To: linux-hotplug@vger.kernel.org
Subject: Re: [linux-usb-devel] [PATCH] fix some hubs and hid devices at startup
Date: Thu, 14 Mar 2002 13:21:47 +0000 [thread overview]
Message-ID: <marc-linux-hotplug-101611215705525@msgid-missing> (raw)
In-Reply-To: <marc-linux-hotplug-101588456410451@msgid-missing>
On Tue, Mar 12, Greg KH wrote:
> On Mon, Mar 11, 2002 at 05:08:37PM -0500, Johannes Erdfelt wrote:
> >
> > The hub driver doesn't talk to devices, so I'll assume you mean the hub
> > thread, which is actually calling the core for enumeration (setting
> > address, fetching descriptors, etc)
>
> Sorry, yes this is what I meant.
>
> > But the enumeration should be finished by the time the hotplug stuff
> > finishes.
> >
> > In that case, nothing should be stomping over each other.
>
> In looking at this some more I agree, it doesn't look like this could
> race with the hub thread.
>
> > Is it that devices don't like how quickly we let the driver talk to it
> > after enumeration?
>
> Ah, this is probably more likely.
>
> The problem looks like the usbdevfs calls are happening at the same time
> the hid driver is also talking to the device.
>
> Olaf, is this what your log messages show?
It seems so. I think a more correct fix would be a lock in the usbcore
code to hold usbdevfs requests when "some bus action" is going on, like
this renumbering. You said there is no lock right now for this case?
Gruss Olaf
--
$ man clone
BUGS
Main feature not yet implemented...
_______________________________________________
Linux-hotplug-devel mailing list http://linux-hotplug.sourceforge.net
Linux-hotplug-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-hotplug-devel
next prev parent reply other threads:[~2002-03-14 13:21 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-03-11 22:08 [linux-usb-devel] [PATCH] fix some hubs and hid devices at startup Johannes Erdfelt
2002-03-12 0:20 ` David Brownell
2002-03-12 20:27 ` Greg KH
2002-03-12 20:29 ` Greg KH
2002-03-12 22:15 ` David Brownell
2002-03-12 22:52 ` Greg KH
2002-03-13 1:52 ` David Brownell
2002-03-14 13:21 ` Olaf Hering [this message]
2002-03-15 18:28 ` Greg KH
2002-05-15 20:25 ` David Brownell
2002-05-15 20:37 ` Olaf Hering
2002-05-15 21:37 ` Johannes Erdfelt
-- strict thread matches above, loose matches on Subject: below --
2002-05-15 20:08 Olaf Hering
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=marc-linux-hotplug-101611215705525@msgid-missing \
--to=olh@suse.de \
--cc=linux-hotplug@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).