From mboxrd@z Thu Jan 1 00:00:00 1970 From: Olaf Hering Date: Thu, 14 Mar 2002 13:21:47 +0000 Subject: Re: [linux-usb-devel] [PATCH] fix some hubs and hid devices at startup Message-Id: List-Id: References: In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: linux-hotplug@vger.kernel.org On Tue, Mar 12, Greg KH wrote: > On Mon, Mar 11, 2002 at 05:08:37PM -0500, Johannes Erdfelt wrote: > > > > The hub driver doesn't talk to devices, so I'll assume you mean the hub > > thread, which is actually calling the core for enumeration (setting > > address, fetching descriptors, etc) > > Sorry, yes this is what I meant. > > > But the enumeration should be finished by the time the hotplug stuff > > finishes. > > > > In that case, nothing should be stomping over each other. > > In looking at this some more I agree, it doesn't look like this could > race with the hub thread. > > > Is it that devices don't like how quickly we let the driver talk to it > > after enumeration? > > Ah, this is probably more likely. > > The problem looks like the usbdevfs calls are happening at the same time > the hid driver is also talking to the device. > > Olaf, is this what your log messages show? It seems so. I think a more correct fix would be a lock in the usbcore code to hold usbdevfs requests when "some bus action" is going on, like this renumbering. You said there is no lock right now for this case? Gruss Olaf -- $ man clone BUGS Main feature not yet implemented... _______________________________________________ Linux-hotplug-devel mailing list http://linux-hotplug.sourceforge.net Linux-hotplug-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-hotplug-devel