From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Brownell Date: Thu, 18 Jul 2002 17:19:25 +0000 Subject: Re: [PATCH] usb.agent should processes usermap before other maps. Message-Id: List-Id: References: In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: linux-hotplug@vger.kernel.org >> If hci_usb shouldn't be claiming specific devices, it's simple >> to teach it not to do so. > > Yeah, I was gonna do that anyway because processing usermap first > doesn't help > when driver is already loaded. > I thought it might be nice if USB core could do that ie something like > USB_IGNORE_DEVICE(xxx, yyy) in the driver id_table. But Johannes > pointed out > that it probably won't be useful for other drivers. And #defining such a thing (a good example of when not to use inline functions :) in your driver means you get to change how it works later. Like if someday you want a single "declare device" macro you can call in two different modes (build your own table with lots of quirk/status handling, or a usb_device_id table), you can change how you use the driver_info (flags --> pointer). > I was gonna say that it would not work but then I noticed that > it's actually fixed in 2002.04.01. > usb.agent that came with RH 7.2 was doing > if [ "$FOUND" = "false" -a -r $MAP_USERMAP ]; > Which means that usermap won't be processed if kernel driver exists > for this device, even if driver ignores these particular ids. Right, that was a bug. I don't recall the context where it made trouble; maybe it was similar to yours. > I didn't notice that you guys got rid of FOUND = false check in > latest usb.agent. Now that this check isn't there it should work > correctly if driver ignores pre-fw ids. Bug reports help move Linux forward ... and patches too. :) - Dave ------------------------------------------------------- This sf.net email is sponsored by:ThinkGeek Welcome to geek heaven. http://thinkgeek.com/sf _______________________________________________ Linux-hotplug-devel mailing list http://linux-hotplug.sourceforge.net Linux-hotplug-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-hotplug-devel