From: Christoph Hellwig <hch@infradead.org>
To: linux-hotplug@vger.kernel.org
Subject: Re: small devfs patch for 2.5.65, plan to replace /sbin/hotplug
Date: Fri, 21 Mar 2003 19:16:06 +0000 [thread overview]
Message-ID: <marc-linux-hotplug-104827432505656@msgid-missing> (raw)
In-Reply-To: <marc-linux-hotplug-104823993005371@msgid-missing>
On Fri, Mar 21, 2003 at 01:40:48AM -0800, Adam J. Richter wrote:
> There have been some devfs clean ups in the stock kernels
> since 2.5.63, so here is a patch so that people have a version
> that applies cleanly:
A bunch of comments:
- your docs mention devfs_only() buts it's gone for good now
- you removed the last users of devfs_alloc_devnum()/devfs_dealloc_devnum(),
please remove the functionality aswell (not exported anyway)
- is the conditional call to init_devfs_fs() in devfs_decode() really
nessecary? I think one explicit call to it in the early boot
process would be much better. If you don't like that at least
mark it unlikely()
- why do you raise the capablities in devfs_register() and
devfs_mk_symlink() (but not devfs_mk_dir()!). I think any driver
code actually calling that must run with raised privilegues already.
- I think renaming base.c to interf{,ace}.c is a good idea. It's
more descriptive and will make the diff a lot easier to read.
-------------------------------------------------------
This SF.net email is sponsored by:Crypto Challenge is now open!
Get cracking and register here for some mind boggling fun and
the chance of winning an Apple iPod:
http://ads.sourceforge.net/cgi-bin/redirect.pl?thaw0031en
_______________________________________________
Linux-hotplug-devel mailing list http://linux-hotplug.sourceforge.net
Linux-hotplug-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-hotplug-devel
next prev parent reply other threads:[~2003-03-21 19:16 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-03-21 9:40 small devfs patch for 2.5.65, plan to replace /sbin/hotplug Adam J. Richter
2003-03-21 19:16 ` Christoph Hellwig [this message]
2003-03-21 20:45 ` Kevin P. Fleming
2003-03-21 23:21 ` Greg KH
2003-03-21 23:41 ` Kevin P. Fleming
2003-03-21 23:54 ` Andrew Walrond
2003-03-21 23:55 ` Greg KH
2003-03-22 0:03 ` Greg KH
2003-03-22 3:39 ` Adam J. Richter
2003-03-22 15:36 ` jordan.breeding
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=marc-linux-hotplug-104827432505656@msgid-missing \
--to=hch@infradead.org \
--cc=linux-hotplug@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).