Re: [PATCH] syntax error in load_drivers, LOADED unset

[Olaf Hering <olh@suse.de>]

 On Mon, Jun 09, David Brownell wrote:

> Olaf Hering wrote:
> >This avoids the ' if [ = false ] ' syntax error:
> >I have seen it also in the debian patch.
> 
> Not needed with that other fix to initialize LOADED at the
> top of the loop ...

I believe the current code is buggy.
We set LOADED to false
'lsmod | grep -q "^$MODULE "' will trigger the blacklist check and the
modprobe.
If the driver is already loaded because another device triggered a load
earlier, or because it was loaded for other reasons, then LOADED will
remain 'false'.
LOADED will eventually become true if a usermode helper $TYPE/$MODULE
exists. If none exists, this message is triggered, which is misleading:
mesg "missing kernel or user mode driver $MODULE "

Was something like this the intention?

...
    for MODULE in $DRIVERS
    do  
        # maybe driver modules need loading
        LOADEDúlse
        lsmod | grep -q "^$MODULE " && LOADED=true
        if [ $LOADED = false ] ; then
...


Gruss Olaf

-- 
USB is for mice, FireWire is for men!


-------------------------------------------------------
This SF.net email is sponsored by:  Etnus, makers of TotalView, The best
thread debugger on the planet. Designed with thread debugging features
you've never dreamed of, try TotalView 6 free at www.etnus.com.
_______________________________________________
Linux-hotplug-devel mailing list  http://linux-hotplug.sourceforge.net
Linux-hotplug-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-hotplug-devel