* [patch] udev: trivial trivialities
@ 2003-10-18 1:23 Robert Love
0 siblings, 0 replies; 2+ messages in thread
From: Robert Love @ 2003-10-18 1:23 UTC (permalink / raw)
To: linux-hotplug
Yah yah, really trivial stuff...
- get_class_device() doesn't need to be exported; it
should be static
- white space cleanup
Patch is against udev-003.
Robert Love
udev-add.c | 2 +-
udevdb.c | 4 ++--
2 files changed, 3 insertions(+), 3 deletions(-)
diff -urN udev-cvs/udev-add.c udev/udev-add.c
--- udev-cvs/udev-add.c 2003-10-17 21:19:40.630564464 -0400
+++ udev/udev-add.c 2003-10-17 21:18:44.257134528 -0400
@@ -101,7 +101,7 @@
return retval;
}
-struct sysfs_class_device *get_class_dev(char *device_name)
+static struct sysfs_class_device *get_class_dev(char *device_name)
{
char sysfs_path[SYSFS_PATH_MAX];
char dev_path[SYSFS_PATH_MAX];
diff -urN udev-cvs/udevdb.c udev/udevdb.c
--- udev-cvs/udevdb.c 2003-10-16 21:04:04.000000000 -0400
+++ udev/udevdb.c 2003-10-17 21:16:31.596302040 -0400
@@ -125,13 +125,13 @@
data = tdb_fetch(udevdb, key);
if (data.dptr = NULL || data.dsize = 0)
return NULL;
-
+
rec = (struct busdb_record *)malloc(sizeof(struct busdb_record));
if (rec = NULL) {
free(data.dptr);
return NULL;
}
-
+
memcpy(rec, data.dptr, sizeof(struct busdb_record));
free(data.dptr);
-------------------------------------------------------
This SF.net email sponsored by: Enterprise Linux Forum Conference & Expo
The Event For Linux Datacenter Solutions & Strategies in The Enterprise
Linux in the Boardroom; in the Front Office; & in the Server Room
http://www.enterpriselinuxforum.com
_______________________________________________
Linux-hotplug-devel mailing list http://linux-hotplug.sourceforge.net
Linux-hotplug-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-hotplug-devel
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [patch] udev: trivial trivialities
@ 2003-10-19 20:57 Greg KH
0 siblings, 0 replies; 2+ messages in thread
From: Greg KH @ 2003-10-19 20:57 UTC (permalink / raw)
To: linux-hotplug
On Fri, Oct 17, 2003 at 09:23:43PM -0400, Robert Love wrote:
> Yah yah, really trivial stuff...
Ah, I like these kinds of patches, it means that everything else is
working for you :)
thanks, I've applied it.
greg k-h
-------------------------------------------------------
This SF.net email sponsored by: Enterprise Linux Forum Conference & Expo
The Event For Linux Datacenter Solutions & Strategies in The Enterprise
Linux in the Boardroom; in the Front Office; & in the Server Room
http://www.enterpriselinuxforum.com
_______________________________________________
Linux-hotplug-devel mailing list http://linux-hotplug.sourceforge.net
Linux-hotplug-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-hotplug-devel
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2003-10-19 20:57 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2003-10-19 20:57 [patch] udev: trivial trivialities Greg KH
-- strict thread matches above, loose matches on Subject: below --
2003-10-18 1:23 Robert Love
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).